Repository navigation
feat: show hit target size suggestions in Gesture Debug - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gesture Debug now shows a Suggestions tab and warning count for current-page interaction targets below 44 pt in either dimension on iPhone, or 28 pt on Mac, including Catalyst. Each suggestion includes the target size, minimum size, identity, source, and geometry coverage so estimated bounds are visible to the user.
Suggestions use the server's current interaction snapshot rather than historical events, continue updating with borders hidden, and clear on navigation, capture stop, and disconnect. The shared size predicate keeps warnings consistent with target-app border colors, including tolerance for floating-point noise at the threshold. Capture exports retain the interaction snapshot and target platform; older server payloads remain supported.
Validation: