📖 feat: Stream Bounded Workspace File Reads - #303
Conversation
|
Head: bfe284e. B2 streams bounded, complete-line workspace reads through the verified descriptor. Wire shapes and whole-file limits for other consumers remain unchanged. Focused verification and independent exact-head review are in progress. |
|
Head: 0c0b303. Fixed R1 (P2): interruption no longer waits for queued-I/O cleanup. Actual FileHandle reads verify cancellation/deadline settlement before drain and eventual file/root closure. Focused checks: 138 passed, 2 existing skips; typecheck, package build, and touched-code formatting passed. Fresh independent exact-head review running. |
|
Head: 0578cb7. Fixed R2 (P2): file/root cleanup follows explicit interruption, not a clock recheck. Swept read admission, scanning, race settlement, ownership, worker handling, and compatibility by invariant. Real queued-I/O tests cover timers firing before the monotonic deadline. Focused checks: 140 passed, 2 existing skips; typecheck, build, touched-code formatting passed. Independent exact-head review running. |
|
Head: 95d50b8. Test-only portability correction: queued-I/O subprocesses disable io_uring so Node 20 file reads cannot bypass the saturation harness. Worker runtime settings are unchanged. Linux Node 20.11.0 and 24.16.0 focused checks each passed 140 tests with 2 existing skips; typecheck, build, and formatting passed. Independent exact-head review running. |
|
Review complete for head 95d50b8: no findings. Prior P2 findings R1, R2, and CI1 are fixed; none rejected. Independent checks also validated 1,605 real-file windows against existing line semantics and protocol validators. Local Linux Node 20/24 focused checks: 140 passed each, 2 existing skips each. Typecheck, package build, and touched-code formatting passed. CI: 10 passed; Lambda MicroVM Runner Image (arm64) still running. No deployment. |
|
@codex review the latest head, final review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Ordinary
read_filerejected small windows from files larger than 1 MiB because it loaded the entire file. Stream complete-line windows through the existing verified descriptor instead.READ_LIMIT_EXCEEDED.Contract and compatibility
Read contract. Request/result shapes, capabilities, and protocol version are unchanged. Preserve UTF-8 replacement decoding, BOM-marked UTF-16, CRLF, and empty-file behavior. Binary bytes remain decoded text; unread content is not validated. Pagination assumes unchanged content across requests.
Search, preview, edit, write, instruction snapshots, and safe parent creation retain their existing limits and semantics. No LibreChat changes or deployment.
Verification
tsc --noEmit, build, Prettier on new files/touched regions, andgit diff --check: passed. Existing unrelated formatting is preserved.Review
0c0b30308b89c34f47c500d53c6fc2766f1a48fc.0578cb79634b218f9571ba17bf629f882d72acad.95d50b848088ebcc48515c61bf0c639edff55fdb. Worker runtime settings are unchanged.Head:
95d50b848088ebcc48515c61bf0c639edff55fdb. Independent exact-head review complete: no findings. CI: 10 checks passed; Lambda MicroVM Runner Image (arm64) remains in progress.Independent review additionally checked 1,605 deterministic real-file windows against whole-text semantics and current validators. Its executable coverage was Linux Node 24 with non-native tests; held-root checks, typecheck, build, and formatting are covered by the implementation checks above, not claimed as independently executed.