fix: portal/twin password counting#8
Open
phutur1st wants to merge 1 commit into
Open
Conversation
bf2fcdf to
b7cf6b3
Compare
Only received form data should affect Evil Portal and Evil Twin credential counts. Client connect/count messages are useful for debugging and session review, but mixing them into credential logs inflated password totals. Keep that activity in separate portal/twin event logs while keeping credential logs form-only. The loot DB version bump forces cached totals to rebuild once with the corrected rule.
b7cf6b3 to
cb8e65b
Compare
Author
TestingTested locally on historical and new captures |
Author
|
Question for @LOCOSP - The core bug (credential counts inflated by client connect/count messages) required roughly ~20 net lines — the is_portal_form_line filter, the count fix in _rebuild_db, and the DB version bump. The remaining ~30 lines come from the new save_portal_activity / save_evil_twin_activity methods and the accompanying portal_events.log / evil_twin_events.log files. The intent was to preserve client connect/count events in a separate debug log rather than discard them silently. Is that debug log worth keeping, or would you prefer a leaner patch that simply discards non-form events and skips the new log files entirely? Happy to revise if simpler is better here. Zdrowie! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Evil Portal and Evil Twin credential counting so only received form data lines are treated as captured passwords.
Previously, client status lines such as client connects and client count updates were saved into the portal/twin capture logs. Because loot totals counted every line in those files, non-credential events inflated the password/capture totals.
Changes
portal_passwords.logevil_twin_capture.logportal_events.logevil_twin_events.logNotes
The loot DB rebuild uses the existing rebuild path. As a result, version
1databases will be regenerated as version2, correcting inflated historical portal/twin counts.Fixes #9