fix: match archibot httpGet.port ignore keys to jsonschema 4.19 json_path - #84
Merged
Merged
Conversation
…path CI pins jsonschema==4.19.0, which emits hyphenated service keys with dot notation (services.archibot-db-gateway), not brackets. The v0.61.0 ignore never matched, so values-dev-tech-support still failed validation.
…path CI pins jsonschema==4.19.0, which emits hyphenated service keys with dot notation (services.archibot-db-gateway), not brackets. The v0.61.0 ignore never matched, so values-dev-tech-support still failed validation.
thepoppingone
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IGNORED_VALIDATION_ERRORSkeys forarchibot/archibot-db-gatewayhttpGet.portto use dot notation (services.archibot-db-gateway), matchingerror.json_pathfromjsonschema==4.19.0(the version pinned in the hook).services['archibot-db-gateway']), so it never matched and CI still failed onvalues-dev-tech-support.yaml.Follow-up to #83. Unblocks cloud-platform-gitops#413.
Test plan
jsonschema==4.19.0thaterror.json_pathis$.platform-managed-chart.services.archibot-db-gateway.livenessProbe.httpGet(and readiness equivalent).revincloud-platform-gitops.pre-commit-config.yaml, re-run PR 413 pre-commit and confirmtech-support instance devpasses withhttpGet.port: 8080.Made with Cursor