feat(gastown): integrate gastown into dev:env secret management#4014
Open
IamCoder18 wants to merge 1 commit into
Open
feat(gastown): integrate gastown into dev:env secret management#4014IamCoder18 wants to merge 1 commit into
IamCoder18 wants to merge 1 commit into
Conversation
Create .dev.vars.example with @from annotations for NEXTAUTH_SECRET and GASTOWN_JWT_SECRET, enabling the dev:env sync system to generate .dev.vars and auto-create Secrets Store entries for gastown locally. Previously gastown hardcoded dev secrets in wrangler.jsonc env.dev.vars, which drifted from .env.local and couldn't benefit from the centralized secret management pipeline.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummarySingle-file addition of Files Reviewed (1 file)
Reviewed by claude-4.6-sonnet-20260217 · 859,000 tokens Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates
services/gastown/.dev.vars.examplewith@fromannotations forNEXTAUTH_SECRETandGASTOWN_JWT_SECRET, enabling thedev:envsync system to generate.dev.varsand auto-create Secrets Store entries for Gastown locally.Closes #4013
Previously Gastown hardcoded dev secrets in
wrangler.jsoncenv.dev.vars, which drifted from.env.localand couldn't benefit from the centralized secret management pipeline. The committedwrangler.jsoncalready has correctsecrets_store_secretsbindings in both top-level (production) andenv.dev(local) sections, so no wrangler config changes are needed.Verification
pnpm dev:envand verify Gastown secrets are generated.Visual Changes
N/A
Reviewer Notes
.dev.vars.example. Thewrangler.jsoncalready had correctsecrets_store_secretsbindings inenv.devfrom a prior commit.GASTOWN_JWT_SECRETmust be added to.env.local; otherwise the placeholder value from.dev.vars.exampleis used.wrangler deployuses top-levelsecrets_store_secretsbindings which are unchanged.