Add sailpoint-app-setup command - #2246
Open
amangalampalli-ks wants to merge 2 commits into
Open
Conversation
amangalampalli-ks
marked this pull request as ready for review
July 28, 2026 10:05
amangalampalli-ks
changed the title
sali-ks
reviewed
Jul 29, 2026
| kind = (folder.get('kind') or 'classic').lower() | ||
| email_q = cls._shell_quote(email) | ||
| uid_q = cls._shell_quote(uid) | ||
| if kind == 'nsf': |
Contributor
There was a problem hiding this comment.
it will not impact case sensitivity I believe
kind == 'nsf':
sali-ks
reviewed
Jul 29, 2026
| flags.append('--write') | ||
| if record.get('can_share'): | ||
| flags.append('--share') | ||
| flag_str = (' ' + ' '.join(flags)) if flags else '' |
Contributor
There was a problem hiding this comment.
what is the purpose of + here?
what if it is like
flag_str = f" {' '.join(flags)}" if flags else ""
sali-ks
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SailPoint Service Mode setup and runtime support so SailPoint can invite users and apply entitlements safely through Commander, including deferred apply until users become Active and SCIM coexistence guards.
Changes
sailpoint-app-setupto create a dedicated SailPoint config record and regenerate Commander-only compose withCOMMANDER_RECORD+SAILPOINT_RECORD