Skip to content

Replace MbedTLS with the SHA stdlib for HMAC signing #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
krynju wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Replace MbedTLS with the SHA stdlib for HMAC signing #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ name = "Azure"
uuid = "34b51195-c7f2-5807-8107-6ca017e2682c"
keywords = ["azure", "cloud", "api", "julia"]
desc = "Julia interface to Azure APIs"
version = "0.5.0"
version = "0.5.1"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
MbedTLS = "739be429-bea8-5141-9913-cc70e7f3736d"
SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce"
Mmap = "a63ad114-7e13-5084-954f-fe012c677804"
OpenAPI = "d5e62ea6-ddf3-4d43-8e4c-ad5e6c8bfd7d"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Expand All @@ -20,7 +20,7 @@ XMLDict = "228000da-037f-5747-90a9-8195ccbf91a5"
[compat]
Downloads = "1"
JSON = "0.21"
MbedTLS = "0.6.8, 0.7, 1"
SHA = "0.7, 1"
OpenAPI = "0.1,0.2"
TimeZones = "1"
URIs = "1.3, 1.4"
Expand Down
2 changes: 1 addition & 1 deletion src/StorageServices/StorageServices.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ using Azure.StorageManagementClient
using Azure.REST
using Azure.REST: AccountKey, service_response, parse_service_response, issuccess
using URIs
using MbedTLS
using SHA: hmac_sha256
using Dates
using Base64
using Mmap
Expand Down
2 changes: 1 addition & 1 deletion src/StorageServices/sas.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function appendSAS(raw_url::String, key::String; permissions::String=SASPermissi
content_language,
content_type
], "\n")
sig = base64encode(digest(MD_SHA256, str_to_sign, base64decode(key)))
sig = base64encode(hmac_sha256(base64decode(key), str_to_sign))

query_params = [
"sv"=>SAS_VERSION,
Expand Down
4 changes: 2 additions & 2 deletions src/rest_api_protocol.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module REST

using URIs
using Downloads
using MbedTLS
using SHA: hmac_sha256
using Dates
using Base64
using XMLDict
Expand Down Expand Up @@ -112,7 +112,7 @@ function sign_sharedkey(req::ServiceRequest, key::String)
print(iob, canonicalize_resource(req.account, req.resource))

signingstr = String(take!(iob))
hmacsign = base64encode(digest(MD_SHA256, signingstr, base64decode(key)))
hmacsign = base64encode(hmac_sha256(base64decode(key), signingstr))
req.headers["Authorization"] = "SharedKey $(req.account):$(hmacsign)"
nothing
end
Expand Down
Loading