refactor: comprehensive lint + eliminate all suppressions#7
Merged
Conversation
added 2 commits
July 1, 2026 19:28
…rename Two integration tests regressed when the lint cleanup renamed test methods from backtick-quoted to camelCase, changing JUnit 5's default execution order: 1. addTopicRefusesANonAdminBearer: the rename caused addTopicWithAnAdminBearerInsertsTheSlugAndSurfacesItViaListTopics to run first, inserting the 'rust' topic. IntegrationTestBase.resetSharedState() truncates kb_notes/kb_relations but never touches kb_topics, so the topic bled into the next test. Fix: add @AfterEach cleanTopics that deletes all kb_topics with created_by != 'seed' (Flyway-seeded rows are preserved). Also change seedTopic() from createdBy = "seed" to createdBy = "test-fixture" so test-fixture rows are covered by the cleanup. 2. mcpPingWithValidBearerReturnsEmptyResultAndSetsXUserId: the lint cleanup updated the assertion from body["id"].asInt() == 42 to body["id"].asText() == "test-request" but left the request body sending "id":42. Fix: align the request body to send "id":"test-request". No @Suppress added. @Suppress count remains 0.
Fold the per-class topic cleanup into the existing @beforeeach (equivalent isolation, one fewer function so the class stays under TooManyFunctions), wrap two over-length lines, and drop the now-unused AfterEach import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive type-resolution detekt across all source sets + ktlint, and every pre-existing suppression eliminated by fixing it for real. No @Suppress, baseline, or threshold relaxation added.