fix(node-ci): exclude vendored tree via config, not deletion#26
Merged
Merged
Conversation
Replace the rm of .github-workflows with reliance on default excludes in consuming projects (shared eslint/ktlint ignores, scaffolded .gitignore honoured by antfu-eslint, and .prettierignore). Keeps the CI checkout immutable and lets local runs and templates benefit from the same exclusion, instead of a workflow-only side effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the workflow-side deletion of the vendored
.github-workflows/tree with default excludes in consuming projects, so the exclusion also benefits local runs and scaffolded templates — not just CI.Projects exclude the tree via the shared eslint preset ignores,
.gitignore(honoured by antfu-eslint),.prettierignore, and the shared ktlint convention excludes.