fix(node-ci): remove vendored actions tree before quality checks#24
Merged
Merged
Conversation
The lint/test job checks out the shared workflows repo into .github-workflows/ to run the setup-node composite action (SHA-pinned via job_workflow_sha, so it must live in the workspace). A workspace-wide lint command such as `eslint .` then scanned that vendored tree and failed on its machine-authored YAML. The vendored actions are only needed for setup-node, so remove the directory immediately afterwards; every quality command then sees only the consuming project's files. Fixes the class of failure globally for all node consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node lint/test job vendors this workflows repo into
.github-workflows/to run the SHA-pinnedsetup-nodecomposite action. A workspace-wide lint command (e.g.eslint .) then scanned that vendored tree and failed on its machine-authored YAML.The vendored actions are only needed for
setup-node, so remove the directory right after — every quality command then sees only the consuming project files. Fixes this class of failure globally for all node consumers.Complements the shared frontend ESLint preset, which also ignores
.github-workflowsas defense-in-depth.