Skip to content

docs: use bundle exec in the custom config example - #492

Merged
JesperDramsch merged 2 commits into
mainfrom
docs/routine-review-proof
Oct 13, 2026
Merged

JesperDramsch merged 2 commits into
mainfrom
docs/routine-review-proof

Conversation

@JesperDramsch

Copy link
Copy Markdown
Owner

DEVELOPMENT.md told readers to run bundler exec jekyll serve for a custom config; the Bundler CLI command is bundle exec, matching the other examples in the file.

Docs-only change. Opened to exercise the webhook-fired review routine; do not merge until the review comment has appeared.

@JesperDramsch
JesperDramsch marked this pull request as draft October 13, 2026 13:30
@JesperDramsch
JesperDramsch marked this pull request as ready for review October 13, 2026 13:30

Copy link
Copy Markdown
Owner Author

Routine review

Request. No linked issue; the PR description asks to change the one custom-config example in DEVELOPMENT.md from bundler exec jekyll serve to bundle exec jekyll serve. That is one file and one line.

Checked against.

  • Date: Tue Oct 13 14:08:03 UTC 2026 (from date).
  • Repo grep for bundler exec|bundle exec in the checkout at cc22d0e (not an external fact).
  • unverified: "the Bundler CLI command is bundle exec" (PR body). I fetched no URL for it. I also did not check whether the bundler executable accepts exec as an alias.

Needs your decision.

  1. pixi.toml:13-19 has seven tasks that still use bundler exec (serve, serve-dev, serve-fast, serve-minimal, build-dev, build-minimal, profile). The request names only DEVELOPMENT.md, so the PR leaves them as they are. Recommendation: if bundler exec is wrong, fix pixi.toml in a separate PR. If it works, the PR's rationale ("the Bundler CLI command is bundle exec") is about consistency only, and the PR text should say so. Either way I would not widen this PR.

Findings.

  • No blocking findings. The diff is one line, DEVELOPMENT.md:108, and bundle exec now matches every other doc and workflow command (README.md:191, TRANSLATION.md:62, tests/README.md:52, .github/workflows/*.yml). The sibling difference in pixi.toml is decision 1.
  • The PR body says "do not merge until the review comment has appeared". The PR is non-draft, so mergeability depends on you.

Tests. The change is docs-only, so no test is expected. There is no invariant test that runs over every instance, for example a check that no doc or config uses bundler exec. Existing suite output, literal (no pyproject.toml or uv.lock, so the npm path ran):

Test Suites: 15 passed, 15 total
Tests:       423 passed, 423 total

npm ci completed. npm test is jest. Ruff was not run because it is part of the uv path, which does not apply here.

Bounds. I read the full diff, the PR body and coding/skills/review/SKILL.md. I grepped the whole repo for bundler exec and bundle exec. I skimmed nothing else. I did not run pytest, ruff or the Playwright e2e tests, and the Jekyll build was not run (docs-only change). .github/claude-review.md does not exist. git rev-parse HEAD equals the payload Head SHA cc22d0e3bef9b05abb0a85238114753775a9405a.


Generated by Claude Code

@JesperDramsch
JesperDramsch marked this pull request as draft October 13, 2026 14:19
@JesperDramsch
JesperDramsch marked this pull request as ready for review October 13, 2026 14:19
@JesperDramsch
JesperDramsch merged commit 92ec495 into main Oct 13, 2026
11 checks passed
@JesperDramsch
JesperDramsch deleted the docs/routine-review-proof branch October 13, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant