Skip to content

DRAFT: Modly Next integration preview (5 pending upstream PRs) - #2

Draft
JayceeB1 wants to merge 7 commits into
mainfrom
integration/modly-next-2026-10-09
Draft

JayceeB1 wants to merge 7 commits into
mainfrom
integration/modly-next-2026-10-09

Conversation

@JayceeB1

@JayceeB1 JayceeB1 commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Purpose

Experimental integration branch, not a release and not intended for immediate merge.

Start from upstream's published v0.4.3 main, then selectively port changes from five still-open upstream pull requests, preserving one commit per upstream PR and retaining the released package version. All edits are isolated on integration/modly-next-2026-10-09; this does not modify fork main or upstream.

Port Source PR Contribution
1 #370 (JayceeB1) Fail-closed storage directory deletion/move safeguards and 12 focused tests
2 #333 (jokrasno) Atomic CLI exports; preserve existing destination on failed download
3 #366 (kevin9327) Regression coverage: cancelling ended jobs should not terminate a loaded worker
4 #364 (iammojogo-sudo) Export live viewer mesh transforms and reset gizmo
5 #334 (securitybrahh) VRAM indicator in the desktop UI

These are adapted patches, not actual merges/cherry-picks of the contributors' Git commits. Please credit original PR authors and treat their source PRs as authoritative.

Verification ledger

  • Mainline baseline: upstream main version 0.4.3 (f11a4d2).
  • Each patch hunk matched current source context, with explicit rejection for ambiguous/missing matches.
  • GitHub compare: 5 new commits, 13 unique files, no modifications to main.
  • Focused safety-guard tests: 12/12 PASS on Node 22/Linux on the standalone guard/tests source, including simulated Windows paths and filesystem temp fixtures.
  • Verify typecheck, lint, Python test suite and Electron build on the combined integration branch.
  • Native Windows runtime/junction tests and manual 3D export validation.
  • Review additive changes in the VRAM indicator and guard against regressions.

Deliberately excluded

  • #358: draft, video artifact pipeline spanning 33 files.
  • #266: critical API authentication work (22 files, currently conflicts); needs a separate security review, not a blind integration.
  • #339: model-folder relocation fix; currently conflicts with published code.
  • #242–#252: older overlapping / stacked series, not directly mergeable. Must deduplicate and rebase/reconcile.
  • Other stale or conflicting PRs pending validation.

Safety / workflow

  • No unconditional merging of outstanding PRs: 16 of 22 were marked non-mergeable directly at inventory time.
  • PR fix(storage): guard recursive deletion and relocation (refs #351) lightningpixel/modly#370 guards paths but does not prove file ownership inside an arbitrary user-selected storage folder.
  • Our integration branch is a snapshot, not a replacement for upstream maintenance. Re-audit/rebase when upstream merges the source PRs.
  • Never merge this draft based solely on patch applicability; CI, Windows smoke, and manual tests remain required.

JayceeB1 commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

Integration inventory follow-up (2026-10-09)

Additional checks on published upstream main:

CI check runs on the staging head: none reported yet at the time of this inventory. The combined preview remains experimental and must not be described as validated or safe for valuable data.

Worktree intentionally unchanged by this note.

JayceeB1 commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

Follow-up integration: draft PR #3 stages the viewer/Library/lineage series on top of this Modly Next branch. It ports distinct behavior from upstream lightningpixel#242, lightningpixel#243, lightningpixel#244, lightningpixel#245, lightningpixel#247, lightningpixel#248, lightningpixel#249 with explicit 0.4.3 adaptations. Old lightningpixel#246 (agent), lightningpixel#250 (mesh optimizer processor replacement), lightningpixel#251 (parameter binding), lightningpixel#252 (large diverged intent/texture stack) remain outstanding. Do not merge #2/#3 or package as safe: no combined CI, Windows runtime or end-to-end mesh testing has run. Integration ledger is at docs/experimental-library-integration-ledger.md in PR #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant