fix: include dataset in all flywire links#87
Merged
Conversation
Consolidate the FAFB and BANC FlyWire URL templates into a single template with a <DATASET> placeholder, and default the FlyWireLink dataset prop to "fafb" so the FAFB links also carry an explicit dataset query parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures the
datasetquery parameter is included on all FlyWire (codex) external links, not just BANC.<DATASET>placeholder.FlyWireLinknow always substitutes the dataset into the URL.FlyWireLink.defaultProps.datasetto"fafb", so the FAFB call site (which passes no dataset) emitsdataset=fafb. The BANC call site continues to passdataset="banc".Notes
fafbmatches codex's default FAFB dataset, so FAFB link behavior is unchanged other than the parameter now being explicit.🤖 Generated with Claude Code