Job detail page improvements by krokicki · Pull Request #391 · JaneliaSciComp/fileglancer

krokicki · 2026-06-19T14:43:05Z

Reworks the job detail page: a new Overview tab that summarizes a job at a glance, cleaner Parameters/log tabs, and polish on the running-service banner. Backend changes snapshot the runtime metadata the Overview needs onto each job at submit time.

Motivation

The job detail page opened on a raw Parameters dump, crammed status and timestamps into the header, and had no single place to answer "what was this job, how did it run, and how did it end?". It also showed null parameter/resource values and downloaded log files under synthetic names. The runtime info a user most wants — the declared tooling (nextflow / apptainer / pixi / conda), the base command, the run directory — was computed at submit time and then discarded, so it could not be shown on a finished job.

What changed

New Overview tab (default)

Added an Overview tab, now the default landing tab, with two responsive boxes that stack on small screens:
- Status — runtime (live elapsed while running, total once finished), queue wait, submitted/started/finished timestamps, and exit code (with a human-readable meaning, e.g. 137 (killed (SIGKILL / out of memory))).
- Execution — app name (links to the GitHub repo when parseable), entry point, type (Batch job / Service), declared runtime tooling as chips, base command, container / container args / conda env when set, and the cluster job id.
Added a Recent output panel showing the tail of stdout (last ~20 lines) with the trailing LSF job-summary footer stripped, plus a Recent errors panel that appears only when stderr is non-empty. Both link through to the full log tabs.
Slimmed the header down to title + status badge + actions.

Parameters and log tabs

The Parameters tab now renders parameters, cluster resources, environment variables, and other launch fields (pre/post-run, container, container args), with null/undefined values stripped from both the display and the downloaded JSON.
Null parameter and cluster-resource values are filtered in submit_job so they are never persisted (no more cpus: null).
Moved "Export params" into the header next to Relaunch; renamed the in-tab button to "Download".
File tabs (Script / Output / Error) show just the filename with the full path on hover, and use a plain right-aligned download icon matching the file browser. Downloads now use the file's real on-disk basename instead of a hardcoded job-<id>-<tab> name. Added a download button to the Script tab to match stdout/stderr.

Running-service banner

Turned the "Open Service" link into a button.
The service URL truncates with an ellipsis instead of wrapping.

Backend: persist runtime metadata

Persist command, conda_env, and the merged requirements onto the job record at submit time, and expose the already-stored work_dir on the API model — these previously existed only transiently during submission.
Alembic migration c7d2f4a9e103_add_runtime_metadata_to_jobs adds the command, conda_env, and requirements columns. Old jobs return null for these and the UI omits the corresponding rows.
get_job_file_paths now returns a browse-linkable work_dir entry alongside script/stdout/stderr.

Implementation notes

New pure frontend helpers in frontend/src/utils/jobDisplay.ts — formatDuration, stripLsfFooter, tailLines, exitCodeMeaning — with unit tests in frontend/src/__tests__/unitTests/jobDisplay.test.ts.
The LSF footer is stripped only in the Overview preview; the full Output Log tab and downloads keep the complete file. The footer marker is a line of dashes immediately followed by a Sender: LSF System line; a non-match leaves the text untouched.
File-path hovers reuse the existing FgTooltip widget for styling consistent with the file browser.
The stdout/stderr queries are shared between the Overview and the log tabs (same query keys), so switching tabs does not refetch.

Testing

Backend: pixi run -e test test-backend — all pass, including new get_job_file_paths work-dir tests in tests/test_apps.py.
Frontend: pixi run test-frontend — all pass, including the new jobDisplay unit tests.
pixi run node-eslint-check, pixi run node-check, and a production pixi run node-build all pass (no new TypeScript errors).
Migration applied via pixi run migrate; c7d2f4a9e103 is the single head.

@StephanPreibisch @JaneliaSciComp/fileglancer

Users can publish their apps to a catalog browsed by everyone, and add listings to their own collection. Adding from the catalog creates an independent UserApp; the listing stores only metadata (no manifest snapshot) so there is no staleness or drift to manage. The Apps page's new "Browse Catalog" and "Add from URL" buttons replace the old single "Add App" entry point. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Trash icon on the app card and Delete button in the info dialog both open a confirmation dialog before calling the remove mutation, matching the Stop Service confirmation pattern in JobDetail. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Replace the standalone /catalog route and the separate Catalog/Jobs navbar entries with a tab bar on /apps that switches between My Apps, App Catalog, and Jobs. The Apps navbar entry now carries the active-job badge that used to live on the Jobs link. Tabs are a small NavLink-based component (not Material Tailwind's Tabs) since the latter is built around in-memory Tabs.Panel content rather than URL routing; NavLink gets us automatic active state from the URL and proper back/forward behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The server-side verify_requirements() check inspected the backend's PATH, but jobs run on the compute node as the user with a different environment. This produced false negatives (tool present on the cluster but missing on the backend blocked submission) and false positives (passed on the backend, failed at runtime). Add build_requirements_check(), which generates a bash snippet from the same requirement parser and tool registry. It runs inside the job after PATH/conda/ env setup, checks tool existence and version constraints (sort -V), aggregates all failures to stderr, and exits non-zero. Failures surface as a FAILED job with the message in stderr.log, shown by the existing JobDetail UI. submit_job no longer hard-fails on the server; the check is embedded in the job script before pre_run/command. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

The mutation hooks expose a single shared isPending flag, so passing it to every ListingCard caused all add/unshare buttons to animate when any one was in flight. Scope each card's pending state to the listing being acted on by matching the mutation's in-flight variables (listing_id). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Remove the inline GitHub URL link from catalog cards and add an info button that opens a ListingInfoDialog, mirroring the "my apps" AppInfoDialog. The dialog shows the URL, branch, and description in the same table layout, plus a "Shared by" row, and surfaces Add/Unshare actions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add a checkbox to the catalog that filters out listings already in the user's apps, reusing the existing myAppKeys set. Updates the empty state to explain when all shared apps are already installed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>