fs: do not treat EPERM as ENOTEMPTY on Windows#5
Open
PickBas wants to merge 1 commit into
Open
Conversation
Signed-off-by: PickBas <sayed.kirill@gmail.com>
434f776 to
2e9d4da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Refs nodejs#56433
fs.rm(..., { recursive: true })on Windows treatsEPERMfromrmdiras "directory not empty" and recurses into children. That's wrong, because on Windows,EPERMmeans "no permission to delete", not "still has contents".Windows now uses its own
notEmptyErrorCodesset that excludesEPERM.Safety
The
EPERMtreatment as non-empty traces to rimraf 2.2: (changelog, commit):This does not apply to Windows, so
EPERMis safely removed fromnotEmptyErrorCodesand is kept for other platforms.Before/After
JS Script used as
rm.js:Before
After