[SDK-115] Push Action Buttons#1063
Open
franco-zalamena-iterable wants to merge 1 commit into
Open
Conversation
franco-zalamena-iterable
changed the base branch from
SDK-115-bcit-ci
to
SDK-115-followup-push-test
franco-zalamena-iterable
force-pushed
the
SDK-115-followup-push-test
branch
from
c5e226c to
bab3c07
Compare
franco-zalamena-iterable
changed the title
franco-zalamena-iterable
force-pushed
the
SDK-115-followup-push-test
branch
from
bab3c07 to
4a6dd2d
Compare
franco-zalamena-iterable
force-pushed
the
SDK-115-followup-push-action-buttons
branch
from
d7ac834 to
a1d701e
Compare
The previous @ignore reason ("action buttons aren't laid out in the collapsed shade") was wrong. Dumping the systemui hierarchy from a CI-mode run shows both action buttons present and clickable in the shade — but their text is rendered as "GOOGLE" / "DEEPLINK" because systemui applies Material's textAllCaps to action-button labels. By.text("Google") never matches. Tiny helper findActionButton(label) uppercases before lookup. Both action button paths (URL handler via "Google", custom action handler via "Deeplink") now pass under the existing Phase B simulated-push path. Local verification (CI mode): $ ./gradlew :integration-tests:connectedDebugAndroidTest \ -Pandroid.testInstrumentationRunnerArguments.class=com.iterable.integration.tests.PushNotificationIntegrationTest \ -Pandroid.testInstrumentationRunnerArguments.ci=true Pixel_3(AVD) - 9 Tests 1/2 completed. (0 skipped) (0 failed) BUILD SUCCESSFUL Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
franco-zalamena-iterable
force-pushed
the
SDK-115-followup-push-action-buttons
branch
from
a1d701e to
475aec8
Compare
sumeruchat
approved these changes
Jun 8, 2026
Contributor
sumeruchat
left a comment
sumeruchat
left a comment
There was a problem hiding this comment.
Approving. CI is green on this HEAD (BCIT 34: 10 run, 1 skipped, 0 failed) with the action-buttons test active. Nice catch on the textAllCaps casing difference across API levels.
Two non-blocking notes: findActionButton has no wait and leans on the 2s sleep after openNotification, so polling up to the notification timeout would harden it against intermittent flake; and ensureUserSignedIn(TestConstants.TEST_USER_EMAIL) logs the stable email in CI, use testUserEmail to match #1061/#1062.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
This pr introduces the Push Action Buttons tests from BCIT on CI