test(logfiles): add unit tests for ignore rules - #3570
Merged
Conversation
Cover the add_ignore_rule -> _get_ignore_rules round trip with ";;" inside the regex (locks in commit 3bf1d5c), rule expiry semantics including the expiry boundary, skipping of lines without the ";;" separator, appending rules to the same ignore file, collection from multiple ignore files, cleanup by ignore file id and combining of ignore regexes for a log file (including the empty regex match-everything hazard).
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a focused unit-test suite to validate cardano_node_tests.utils.logfiles ignore-rule behavior, ensuring rule file parsing, expiry semantics, and regex-combination edge cases stay stable across future changes.
Changes:
- Adds round-trip tests for
add_ignore_rule()→_get_ignore_rules()including embedded";;"handling and “skip lines without separator” behavior. - Adds expiry-boundary tests for ignore rules (
0 < skip_after < timestampsemantics) and cleanup coverage viaclean_ignore_rules(). - Adds tests for
_get_ignore_regex()combining logic (glob matching, deduplication, multi-regex alternation) including the empty-regex match-everything hazard.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover the add_ignore_rule -> _get_ignore_rules round trip with ";;" inside the regex (locks in commit 3bf1d5c), rule expiry semantics including the expiry boundary, skipping of lines without the ";;" separator, appending rules to the same ignore file, collection from multiple ignore files, cleanup by ignore file id and combining of ignore regexes for a log file (including the empty regex match-everything hazard).