Bump herald to 0.1.2.0 and herald-release action to 0.0.2.0 - #1296
Open
carbolymer wants to merge 1 commit into
Open
Bump herald to 0.1.2.0 and herald-release action to 0.0.2.0#1296carbolymer wants to merge 1 commit into
carbolymer wants to merge 1 commit into
Conversation
carbolymer
requested review from
a team,
CarlosLopezDeLara,
Jimbo4350,
disassembler,
erikd and
palas
as code owners
August 18, 2026 20:28
Contributor
There was a problem hiding this comment.
Pull request overview
Updates repository release/changelog tooling to use herald 0.1.2.0, aligning CI actions and the dev shell with the newer herald version via the cardano-dev flake input.
Changes:
- Bump
cardano-dev(and related Nix inputs) inflake.lock. - Update the release workflow to use
herald-release-0.0.2.0and explicitly pinherald-reftoherald-0.1.2.0. - Update the PR changelog check workflow to pass
herald-refso it no longer relies on the0.1.1.0default.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
flake.lock |
Updates pinned Nix inputs, including cardano-dev, to pull in herald 0.1.2.0 via the dev environment. |
.github/workflows/release.yml |
Bumps herald-release action and pins herald-ref to herald-0.1.2.0 for releases. |
.github/workflows/check-pr-changelog.yml |
Adds herald-ref input to herald-validate to ensure validation runs with herald 0.1.2.0. |
.changes/20260818_cardano-api_bump_herald_tooling.yml |
Adds a changelog fragment documenting the herald tooling bump. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1,9 @@ | |||
| project: cardano-api | |||
|
|
|||
| pr: 0 | |||
carbolymer
force-pushed
the
mgalazyn/chore/bump-herald
branch
from
August 18, 2026 20:32
6179b5c to
a4e3763
Compare
Jimbo4350
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This updates the herald changelog tooling used by this repository:
release.yml: theherald-releaseaction is bumped fromherald-release-0.0.1.0toherald-release-0.0.2.0.herald-validateandherald-releasenow pass an explicitherald-ref: github:input-output-hk/cardano-dev/herald-0.1.2.0.The actions fetch the herald binary at runtime from their
herald-refinput, whose built-in default is stale atherald-0.1.1.0, so bumping the action tag alone would not update the binary.The override also matters for correctness: the
herald-release-0.0.2.0script was rewritten for per-project fragment directories, which only exist in herald 0.1.2.0.flake.lock: thecardano-devinput is updated to the latestmain, so the dev shell provides herald 0.1.2.0 as well.This also re-locks cardano-dev's transitive
haskellNixsubtree, because cardano-dev switched itshaskellNixinput from a fork back toinput-output-hk/haskell.nixbetween the two pins, and keeping the old transitive entries would fail pure evaluation.How to trust this PR
flake.lockdiff touches only thecardano-devnode and nodes scoped under it (cardano-dev/haskellNix/...); none of cardano-api's own inputs moved.check-pr-changelog.yml, so a green "Check changelog fragments" status shows herald 0.1.2.0 validating this repository.Checklist
.changes/