Conversation
|
💬 Discussion in Slack: #pr-review-cli-371-feat-pam-ssh-session-log-parsing-in-gateway Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 3 · PR risk: 0/10 |
|
| Filename | Overview |
|---|---|
| packages/pam/handlers/ssh/proxy.go | Integrates gateway-side rendering and echo-aware logging, but keeps channel-sensitive parser and buffer state on the connection-wide proxy. |
| packages/pam/handlers/ssh/terminal.go | Adds bounded ANSI rendering and echo suppression, although its state is unsafe when shared across concurrent SSH channels. |
| packages/pam/handlers/ssh/terminal_test.go | Covers parsing and single-channel recording behavior but does not exercise concurrent channels on one SSH connection. |
| packages/pam/session/logger.go | Extends the session-event schema with a backward-compatible rendered marker. |
| go.mod | Adds the ANSI parser dependency and its transitive dependency updates. |
Reviews (1): Last reviewed commit: "feat(pam): ssh session log parsing in ga..." | Re-trigger Greptile
Description 📣
Moves SSH session log parsing to the gateway
Type ✨