Conversation
|
💬 Discussion in Slack: #pr-review-cli-366-feat-pam-iam-auth-for-postgres Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
|
| Filename | Overview |
|---|---|
| packages/pam/aws_rds_auth.go | Adds AWS configuration caching, role assumption, and RDS token generation; the cache is unbounded and token generation can consume the connection test's full timeout. |
| packages/gateway-v2/test_connection_handler.go | Adds IAM token generation before PostgreSQL connection testing, making AWS setup and database verification share one timeout budget. |
| packages/pam/pam-proxy.go | Generates and injects an RDS IAM token for PostgreSQL sessions while preserving password authentication for other methods. |
| packages/pam/session/credentials.go | Propagates AWS region and role ARN from the API credential response into cached PAM session credentials. |
| packages/api/model.go | Extends the PAM session credential API model with optional AWS IAM configuration fields. |
| go.mod | Adds the AWS RDS authentication module and promotes directly imported AWS SDK modules to direct dependencies. |
Reviews (1): Last reviewed commit: "feat(pam): iam auth for postgres" | Re-trigger Greptile
Description 📣
iam auth for postgres
Type ✨