Skip to content

fix(preview): 将 consumer smoke 与 Pages 交付解耦 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoland merged 1 commit into from
Aug 18, 2026
Merged

fix(preview): 将 consumer smoke 与 Pages 交付解耦 #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/pages-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,6 @@ jobs:
--commit-hash=${{ needs.identity.outputs.head_sha }}
--commit-dirty=false

- name: Smoke-test the stable preview URL and native facade
run: node controller/scripts/verify-pages-deployment.mjs
env:
CLOUDFLARE_PAGES_DEPLOYMENT_ID: ${{ steps.pages.outputs.pages-deployment-id }}
CLOUDFLARE_PAGES_DEPLOYMENT_URL: ${{ steps.pages.outputs.pages-deployment-alias-url }}
INKCRE_EXPECTED_PAGES_ORIGIN: https://preview-client-web-pr-${{ needs.identity.outputs.pull_number }}.${{ vars.CLOUDFLARE_PAGES_PROJECT }}.pages.dev
INKCRE_PREVIEW_PRODUCER: candidate/extensions/twitter/package.json

- name: Report the pull-request deployment
if: ${{ always() && steps.github-deployment.outputs.deployment_id != '' }}
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
Expand Down
4 changes: 3 additions & 1 deletion docs/40-deployment/web-delivery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ The Toolkit places read-only native Extension snapshots and preview Releases bes
app build, using the stable alias branch `preview/client-web/pr-<number>`. This is a preview
projection, not Registry publication: the workflow has no
`INKCRE_EXTENSION_REGISTRY_TOKEN`. It registers a transient GitHub `preview` deployment, deploys
through Pages, smoke-tests the stable alias, and reports success or failure.
through Pages and reports the provider deployment result. It does not turn edge propagation,
deep route traversal, cache behavior, or byte comparison into synchronous delivery gates; consumer
acceptance is a separate black-box activity.

When an eligible internal PR closes, [`.github/workflows/pages-cleanup.yml`](../../.github/workflows/pages-cleanup.yml)
replaces only that exact preview alias with a closed-page tombstone. Manual cleanup accepts an
Expand Down
Loading