Skip to content

feat(ai-config): mcp config add assistant choices#1684

Merged
damyanpetev merged 32 commits into
masterfrom
mstoyanova/update-mcp-config-agent-agnostic-restore
May 13, 2026
Merged

feat(ai-config): mcp config add assistant choices#1684
damyanpetev merged 32 commits into
masterfrom
mstoyanova/update-mcp-config-agent-agnostic-restore

Conversation

@Marina-L-Stoyanova
Copy link
Copy Markdown
Contributor

@Marina-L-Stoyanova Marina-L-Stoyanova commented May 11, 2026

…date related prompts

Description

enhance MCP configuration for multiple coding assistants

Related Issue

Closes #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring / code cleanup
  • Build / CI configuration change

Affected Packages

  • igniteui-cli (packages/cli)
  • @igniteui/cli-core (packages/core)
  • @igniteui/angular-templates (packages/igx-templates)
  • @igniteui/angular-schematics (packages/ng-schematics)
  • @igniteui/mcp-server (packages/igniteui-mcp)

Checklist

  • I have tested my changes locally (npm run test)
  • I have built the project successfully (npm run build)
  • I have run the linter (npm run lint)
  • I have added/updated tests as needed
  • My changes do not introduce new warnings or errors

Additional Context

image

Marina-L-Stoyanova and others added 2 commits May 11, 2026 14:36
…date related prompts

Co-authored-by: Copilot <copilot@github.com>
…and enhance related prompts

Co-authored-by: Copilot <copilot@github.com>
@Marina-L-Stoyanova Marina-L-Stoyanova marked this pull request as ready for review May 11, 2026 12:08
Copilot AI review requested due to automatic review settings May 11, 2026 12:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the AI configuration flow to make MCP server configuration assistant-agnostic (VS Code vs Cursor/Claude Code/etc.) and to separate MCP configuration from AI “skills and instructions” generation.

Changes:

  • Adds assistant-specific MCP config targets (path + root key) and updates MCP writer to support multiple assistants.
  • Extends both the CLI command and Angular schematic to accept/prompt for “assistant(s)” separately from “agent(s)”.
  • Updates/extends unit and schematic tests and schema prompts/messages to reflect the split between MCP configuration and skills/instructions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
spec/unit/ai-config-spec.ts Updates CLI unit tests for new assistant/agent prompting and MCP behavior.
packages/ng-schematics/src/cli-config/index.ts Updates schematic logic to configure MCP per selected assistant(s).
packages/ng-schematics/src/cli-config/index_spec.ts Adds schematic tests for assistant-specific MCP output paths and root keys.
packages/ng-schematics/src/cli-config/ai-config-schema.json Adds assistant option (prompt + enum) and updates agent prompt messaging.
packages/core/util/mcp-config.ts Introduces assistant MCP config map and changes addMcpServers to be assistant-based.
packages/cli/lib/commands/ai-config.ts Adds assistant prompting/selection and routes MCP config generation accordingly.
Comments suppressed due to low confidence (1)

packages/cli/lib/commands/ai-config.ts:143

  • The handler configures MCP servers via configureMCP(assistants) and then calls configure(agents) which also configures MCP (defaulting to VS Code). This causes duplicate writes and ignores the user’s assistant selection (e.g. selecting --assistant none or choosing “None” interactively still results in VS Code MCP configuration). Pass the selected assistants into configure(...) and/or refactor so MCP is configured exactly once and respects an explicit “none” selection.
		if (!assistants?.length) {
			assistants = await promptForAssistant();
		}
		if (!agents?.length) {
			agents = await promptForAgents();
		}

		GoogleAnalytics.post({
			t: "event",
			ec: "$ig ai-config",
			ea: `agent: ${agents.join(", ") || "none"}`
		});

		if (assistants.length) {
			configureMCP(assistants);
		}

		if (!agents.length) {
			Util.log("No AI configuration selected. Skipping.");
			return;
		}
		await configure(agents);
	}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/ng-schematics/src/cli-config/index.ts Outdated
Comment thread packages/cli/lib/commands/ai-config.ts Outdated
Comment thread packages/cli/lib/commands/ai-config.ts Outdated
Comment thread spec/unit/ai-config-spec.ts Outdated
Marina-L-Stoyanova and others added 4 commits May 11, 2026 16:50
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@coveralls
Copy link
Copy Markdown

coveralls commented May 12, 2026

Coverage Status

coverage: 87.329% (+0.1%) from 87.227% — mstoyanova/update-mcp-config-agent-agnostic-restore into master

@damyanpetev damyanpetev changed the title Mstoyanova/update mcp config agent agnostic restore feat(ai-config): mcp config add assistant choices May 12, 2026
@damyanpetev damyanpetev force-pushed the mstoyanova/update-mcp-config-agent-agnostic-restore branch from e00b27e to 487bb0a Compare May 12, 2026 14:28
Comment thread packages/cli/lib/commands/new.ts Outdated
Comment thread packages/cli/lib/commands/new.ts Outdated
choices: [...AI_AGENT_CHOICES, "none"] as string[],
type: "array"
})
.option("assistants", {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, have we considered naming this something else, like --mcp?

Comment thread packages/core/util/mcp-config.ts Outdated
Comment thread packages/core/util/mcp-config.ts Outdated
Comment thread packages/core/util/mcp-config.ts Outdated
Comment thread packages/cli/lib/commands/new.ts
@damyanpetev
Copy link
Copy Markdown
Member

  • Changelog + Readme

@damyanpetev damyanpetev merged commit e2a1d67 into master May 13, 2026
3 checks passed
@damyanpetev damyanpetev deleted the mstoyanova/update-mcp-config-agent-agnostic-restore branch May 13, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants