Dataverse topic class term uri - #12614
Conversation
Merge "develop" into "master" for 6.10 release
merge develop into master for 6.10.1
Merge develop into master for 6.11
…taverse_topicClassTermURI
pdurbin
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
| <topcClas subjectScheme="LOC Subject Headings" schemeURI="http://www.loc.gov/catdir/cpso/lcco/lcco.html">Elections -- California</topcClas> | ||
| ]]></xhtml:samp> | ||
| </xhtml:div> | ||
| </xhtml:div> |
There was a problem hiding this comment.
@ffritze I'm just leaving this comment at the bottom. Tests are not passing. I'm seeing errors like this:
[ERROR] Failures:
[ERROR] DdiExportUtilTest.testJson2DdiNoFiles:119
Expecting:
<control instance> and <test instance> to be similar
Expected attribute name '/codeBook[1]/stdyDscr[1]/stdyInfo[1]/subject[1]/topcClas[1]/@vocab' - comparing <topcClas...> at /codeBook[1]/stdyDscr[1]/stdyInfo[1]/subject[1]/topcClas[1]/@vocab to <topcClas...> at /codeBook[1]/stdyDscr[1]/stdyInfo[1]/subject[1]/topcClas[1]
expected:<<topcClas vocab="TC Vocabulary" vocabURI="http://www.topicclass.com/one" xmlns="ddi:codebook:2_5">TC Value 1</topcClas>> but was:<<topcClas schemeURI="http://www.topicclass.com/one" subjectScheme="TC Vocabulary" xmlns="ddi:codebook:2_5">TC Value 1</topcClas>>>
[ERROR] DdiExportUtilTest.testJson2DdiNoFilesTermsOfUse:172
Expecting:
<control instance> and <test instance> to be similar
Expected attribute name '/codeBook[1]/stdyDscr[1]/stdyInfo[1]/subject[1]/topcClas[1]/@vocab' - comparing <topcClas...> at /codeBook[1]/stdyDscr[1]/stdyInfo[1]/subject[1]/topcClas[1]/@vocab to <topcClas...> at /codeBook[1]/stdyDscr[1]/stdyInfo[1]/subject[1]/topcClas[1]
expected:<<topcClas vocab="TC Vocabulary" vocabURI="http://www.topicclass.com/one" xmlns="ddi:codebook:2_5">TC Value 1</topcClas>> but was:<<topcClas schemeURI="http://www.topicclass.com/one" subjectScheme="TC Vocabulary" xmlns="ddi:codebook:2_5">TC Value 1</topcClas>>>
Can you please take a look?
There was a problem hiding this comment.
Hi @pdurbin , I have updated my feature branch. I have decided not to change the src/test/resources/xml/xsd/ddi-codebook-2.5/ddi_codebook_2_5.xsd because it is loaded via the internet here src/test/java/edu/harvard/iq/dataverse/export/ddi/dataset-finch1.xml and therefore cannot be changed directly. So I have just made minimal changes to the DDI Exporter keeping the old attribute names and updating the metadata field from topicClassVocabURI to topicClassTermURI
There was a problem hiding this comment.
My main focus lay on the OAI oai_datacite export which is now working as expected.
…taverse_topicClassTermURI
This reverts commit 5a03c25.
| @@ -0,0 +1,38 @@ | |||
| Analogue to the addition of a termURI field to the keywords in the citation metadata blocks, the same idea should also be applied to the topicClassification fields: | |||
|
|
|||
| add a new subfield topicClassTermURI to the citation metadata block | |||
There was a problem hiding this comment.
I'm confused. In this pull request should scripts/api/data/metadatablocks/citation.tsv be updated to include a new field?
Assuming so, this release note snippet should also include a ## Upgrade instructions section at the bottom explaining how to load it and how to update Solr to include the new field. https://github.com/IQSS/dataverse/releases/tag/v6.8 is probably a decent example. Here's a screenshot:
| "typeName": "topicClassTermURI", | ||
| "multiple": false, | ||
| "typeClass": "primitive", | ||
| "value": "http://www.topicClass.com/one" |
There was a problem hiding this comment.
Checks are failing:
We should fix this. Don't worry, we'll help. 😄
2 participants
What this PR does / why we need it:
It adds a valueURI attribute for topicClassification subjects in the exporter implementation and adapts attributes in the
topicClassification context.
Which issue(s) this PR closes:
Special notes for your reviewer:
I think I have covered all the topic Classification logic. I am not quite sure if this is demanded but I could easily remove some parts of my implementation.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: