Skip to content

Guestbook ID over 127 could not be assigned to a Dataset via the API #12592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qqmyers merged 1 commit into from
Aug 19, 2026
+4 −1
Merged

Guestbook ID over 127 could not be assigned to a Dataset via the API #12592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/release-notes/12556-can-not-set-guestbook-with-id-over-127.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## Bug ##
Fixed bug when calling PUT api/datasets/{datsetId}/guestbook body = {id over 127}. Values for Guestbook IDs over 127 are no longer failing.

2 changes: 1 addition & 1 deletion ...main/java/edu/harvard/iq/dataverse/engine/command/impl/UpdateDatasetGuestbookCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public Dataset execute(CommandContext ctxt) throws CommandException {
// Make sure the requested guestbook is available via the dataset's ancestry
final List<Guestbook> guestbooks = dataset.getOwner().getAvailableGuestbooks();
for (Guestbook gb : guestbooks) {
if (gb.getId() == guestbook.getId()) {
if (gb.getId().equals(guestbook.getId())) {
Comment thread
qqmyers marked this conversation as resolved.
allowedGuestbook = gb;
break;
}
Expand Down
Loading