Skip to content

T36 data format v2#37

Open
jgroehl wants to merge 67 commits into
mainfrom
T36-DataFormatV2
Open

T36 data format v2#37
jgroehl wants to merge 67 commits into
mainfrom
T36-DataFormatV2

Conversation

@jgroehl

@jgroehl jgroehl commented Jun 26, 2023

Copy link
Copy Markdown
Member

No description provided.

Scott Miller and others added 28 commits June 2, 2022 10:56
…-device-and-data

1 create converter for imagio pa device and data
…a-device-and-data

1 create converter for imagio pa device and data
…smiller-main

# Conflicts:
#	examples/python/visualise_zenodo_example_data.py
#	pacfish/core/Metadata.py
#	requirements.txt
@codecov-commenter

codecov-commenter commented Jul 7, 2023

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 37.50000% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.92%. Comparing base (4dee0db) to head (389f428).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pacfish/api/adapters/Imagio_File_Converter.py 27.67% 115 Missing ⚠️
pacfish/qualitycontrol/ConsistencyChecker.py 57.14% 6 Missing ⚠️
pacfish/iohandler/file_reader.py 75.00% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   89.46%   80.92%   -8.55%     
==========================================
  Files          19       20       +1     
  Lines         997     1195     +198     
==========================================
+ Hits          892      967      +75     
- Misses        105      228     +123     
Flag Coverage Δ
pytests 80.92% <37.50%> (-8.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgroehl

jgroehl commented Jun 22, 2024

Copy link
Copy Markdown
Member Author

@amasmiller is there any chance to still test if the proposed changes to the data format will work for you?
It is a minor change that re-defined the definition of "frame", where a list of wavelengths is now kept separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants