Refactor JWTTokenProvider to accept KmsClient directly#413
Closed
mcollins-ttd wants to merge 3 commits into
Closed
Refactor JWTTokenProvider to accept KmsClient directly#413mcollins-ttd wants to merge 3 commits into
mcollins-ttd wants to merge 3 commits into
Conversation
Replace the `Supplier<KmsClientBuilder>` + `JsonObject` constructor with a pre-built `KmsClient`, and extract `buildKmsClient(JsonObject)` as a static factory. Make `JwtSigningException` a static nested class so callers no longer need an enclosing instance to construct it. Update `OperatorJWTTokenProvider` to accept explicit `issuerUrl` and `optOutUrl` strings instead of a raw config object. Wire everything up in `Main`.
mcollins-ttd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
Supplier<KmsClientBuilder>+JsonObjectconstructorwith a pre-built
KmsClient, and extractbuildKmsClient(JsonObject)as a static factory.
Make
JwtSigningExceptiona static nested class so callers no longerneed an enclosing instance to construct it.
Update
OperatorJWTTokenProviderto accept explicitissuerUrlandoptOutUrlstrings instead of a raw config object. Wire everything upin
Main.Fix comments about
subandaudclaims.Fix swapped issuer/audience in debug log.