Extract GTM container IDs from audit evidence - #1220
Open
ChristianPavilonis wants to merge 1 commit into
Open
ChristianPavilonis wants to merge 1 commit into
ChristianPavilonis wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
crates/trusted-server-cli/src/commands/audit/generate/analyzer.rscrates/trusted-server-cli/src/commands/audit/generate/mod.rsCloses
Closes #1219
Test plan
Both new regression tests failed before the fix by returning the full URL instead of
GTM-ABC123, then passed after the fix.cargo test --package trusted-server-cli --target x86_64-unknown-linux-gnu gtm_container_id./scripts/test-cli.sh, including opt-in browser fixturescargo test-fastly && cargo test-axum && cargo test-cloudflare && cargo test-spincargo test --manifest-path crates/trusted-server-integration-tests/Cargo.toml --test parity, 14 passedcargo clippy-fastly && cargo clippy-axum && cargo clippy-cloudflare && cargo clippy-cloudflare-wasm && cargo clippy-spin-native && cargo clippy-spin-wasm && cargo clippy-cli && cargo clippy-codegencargo fmt --all -- --checkcd crates/trusted-server-js/lib && node build-all.mjscd crates/trusted-server-js/lib && npx vitest run, 1,155 passedcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatNo deployment or manual Fastly smoke test performed. This changes only CLI extraction logic and its tests.
Checklist
unwrap()or logging changes