Add the integration provider seam design spec - #1084
Conversation
6364acc to
18b65ff
Compare
18b65ff to
616b740
Compare
The provider series design specs move to the spec-only PR (IABTechLab#1084) so they can be reviewed before the code that implements them. Three doc comments cited those files by repository path, which no longer resolves from this branch. Refer to each document by name instead, so the comment stays true whichever PR is read first.
3c7bc27 to
1800604
Compare
aram356
left a comment
There was a problem hiding this comment.
Summary
Thank you for this, and for §8 in particular. Publishing what implementing the seam actually found, including three items that say your own work is not finished, is the right instinct and it is what makes the design half of this trustworthy.
The design is accepted. §3.6's rule is correct, and it is the rule the work below implements. Things the host supplies are platform services. Things a vendor supplies are capabilities of that vendor's module. What is being changed is the order and the structure, not the direction.
Five changes to sequencing and structure follow. Tell me where the reasoning is wrong and I will change my view, but I want these settled before more code lands on the current shape. The two items that need wider sign-off are named at the end.
1. One crates/trusted-server-integrations crate first, with a discovering build.rs
Move all thirteen integrations into a single crate and generate the registration table at build time by scanning the crate's own directories, in the manner crates/trusted-server-js/build.rs already scans dist/tsjs-*.js.
This is the change that delivers the neutrality goal. Core stops naming vendors in builders(), in validate_enabled_integrations, and in migration_guards.rs, and it stops naming them because nobody writes the list, not because the list moved. Three of §1's four hardcoded vendor tables become generated output.
It also resolves several of §8's findings without further design:
- §8.2, the hand-carried module hash and its line-ending fragility, goes away because hashes are generated exactly as core's are today.
- §8.6, a module's
validaterunning nowhere, is solvable in the generated table. - §1.2, the compile-time JS map, is solved by one scan that finds Rust and TypeScript together.
- The
migration_guards.rsdrift is structurally impossible once generated. Worth noting that this drift is not hypothetical:osanois registered inbuilders()and has no entry inmigration_guards.rsat all onmain. Nobody noticed because both lists are hand-written.
prebid stays in core as protocol support, as §3.4 already says.
The runtime injection seam in §3.1 is not required for any of the thirteen integrations you have, because they are all compiled from source in this repository. It becomes the right mechanism when a genuinely external vendor crate exists, and it should be added then, with that vendor as its first consumer.
2. Crate layout follows from that
§4 proposes nine vendor crates, one PR each. We are not doing that now. One crate holds all thirteen integrations, and a vendor gets its own crate when that vendor takes over maintaining it, which none of them does today. Every integration on main imports the same roughly twelve crates, all of which core already depends on, so nothing about dependencies argues for splitting them either. Splitting later is a directory move against a module that already has clean boundaries.
Two consequences for what is in #1094 now:
- Directory name equals package name, as everywhere else in the repository. The crate is
crates/trusted-server-integrations.crates/geo/fastlyas packagetrusted-server-geo-fastlybreaks that convention, andcrates/geo/is a category folder holding one item. - Host code stays in its adapter.
FastlyPlatformGeois 52 lines that already live atcrates/trusted-server-adapter-fastly/src/platform.rs:687, and the Fastly adapter is its only possible consumer. Extracting it into a crate gains nothing and contradicts §3.6's own rule that host-supplied things are platform services. The same applies to the 103-line Fastly device provider.crates/edgecookie/contains only a README and should be deleted until a vendor crate lands.seam-probeis a test fixture and should not be a permanent workspace member.
3. Permissions policy belongs in trusted-server.toml; permissions.yaml should not exist
Policy belongs in a [permissions] section of trusted-server.toml, beside the existing [consent]. We should not add a second configuration format, and policy should not be compiled into the binary.
The permission-model spec's §3.1 gives the reason for YAML. The draft required policy to flow through the runtime config pipeline, and that activation apparatus does not exist. That conflates two things. ts config push does exist. It publishes trusted-server.toml as a blob envelope, and TrustedServerAppConfig already carries the entire Settings struct. What does not exist is the staged multi-revision activation protocol the draft designed, with fleet quiescence, admission leases, and a hash-linked journal. No other setting needs that machinery. The publisher domain, the proxy secret, the EC passphrase, and every integration config all push atomically today, and policy is not different in kind.
What the move gains:
- One place to configure everything. Today policy is the only control that bypasses
ts config validateandts config push, and it is the most compliance-sensitive one. - The validation we already have, being
deny_unknown_fields,Validate, and startup errors, instead of a bespoke parser reimplementing duplicate-key and case-collision checks. - A publisher can correct a jurisdiction rule with a config push rather than rebuilding and redeploying a WebAssembly binary. For a compliance control that may have to change on a regulator's timeline, that difference is the point.
- §3.1's own recorded defect, that the
include_str!path reaches above the crate root, disappears.
Alongside the move, please trim the fifty-three Data Uses that have no signal mapping and no enforcement point. Only two carry enforcement weight today. Moving fifty-three inert flags into trusted-server.toml would carry the misleading operator view across rather than fix it, and the spec already acknowledges this departs from its own rule that a permission appears only with both a mapping and an enforcement point.
4. The EC provider spec rebases onto 1 and 3
Rewritten against a seam that already exists and policy that lives in settings, the EC provider work is materially smaller than #1043 as it stands:
- No
RuntimeServices::ec_providerslot to add and then delete, and noresolved_ec_providersecond field. Note that #1094 currently has both, plus the registration path, so identity has three injection paths where §3.6 specifies one. §3.6's sentence that theec_providerslot "goes" is not yet honored. - No per-adapter resolution divergence. Related, and worth fixing wherever this lands: on #1094
resolve_geo_providerandresolve_device_providerreturnResultand fail loudly on a bad selector, whileresolve_ec_providerreturns a bareOptionand falls back silently. §3.6 says an unresolvable selector is a startup error. - No double configuration migration. This is the strongest reason for the reordering. As it stands, #1043 migrates operators from
[ec] passphraseto[ec.providers.hmac], and §3.6 with sign-off row 8 then migrates them again to[integrations.<id>]. Two breaking configuration changes in one release cycle, the second withdrawing the first. Reordered, operators migrate once, into the final shape.
5. Some of this belongs in edgezero, not Trusted Server
edgezero-core already owns the platform layer, being app_config, blob_envelope, config_store, secret_store, key_value_store, store_registry, the router, the middleware, and the four adapters. Hooks::stores() returning StoresMetadata is already the seam run_app uses to inject store registries. Before we build more platform machinery in this repository, we should be explicit about which side of that line each piece sits on.
- The Fastly composition gap (§8 item 7) is probably an edgezero fix rather than a Trusted Server one.
trusted-server-adapter-fastlywrapsedgezero-adapter-fastly. If a deployment composes its modules throughHooks, the pattern already exists upstream and no Trusted Server adapter needs a new library target. Adding a[lib]here would work around the absence of something that may already exist one level down. RuntimeServicesoverlaps edgezero substantially. It carries a config store, a secret store, a KV store, an HTTP client, and a backend.edgezero-coremodels all five. Adding identity, device, and geo provider slots to it builds up a second platform abstraction beside edgezero's rather than using edgezero's.PlatformGeohas no edgezero counterpart. There is no geo abstraction inedgezero-coretoday. Either a geo lookup is a host capability edgezero should expose the way it exposes a KV store, or it stays here. Whichever it is, that should be a stated call rather than a default that follows from where the code happens to have been written.TrustedServerAppimplementsHooks::name()andHooks::routes()but notHooks::stores()(crates/trusted-server-adapter-cloudflare/src/app.rs:332). The store-injection seam edgezero already provides is unused here, which is worth resolving before we design another one.
Which of these should move is a question for whoever owns edgezero. I would rather ask it now than build a second mechanism here and answer it afterwards. It also makes change 1 smaller: if composition runs through Hooks, the integrations crate needs less new machinery than either this spec or #1094 assumes.
Spec corrections, verified against the tree
- Five of the seven specs are statused "Implemented" for code that is not on
main.EdgeCookieProvider,PermissionSet, andresolve_from_clientare all absent fromorigin/main. Merging this set as written would tell every later reader that shipped behavior exists when it does not. Please status everything unmerged as "Proposed". - §4, "thirteen vendor files" in
migration_guards.rs, is wrong. There are eighteen vendor files across twentyintegrations/entries;nextjsalone contributes six. Thirteen is the count of builders. And as above,osanohas no entry at all, which §4's migration plan depends on. - §3.5, GPT diagnostics "called by name from all four adapters", undercounts. There are nine
prepare_requestcall sites plus onefinalize_response, so the hook work in §3.5 is larger than stated. - §8.3, "a provider is resolved more than once per request", does not hold on
main. No integration or proxy calls geo. A real double resolution does exist, but it is core against core:handle_auctionatauction/endpoints.rs:262and the adapter'sbuild_ec_contextboth calllookuponPOST /auction. The underlying gap, that there is no per-request provider context, is real and worth keeping. - §8.5 understates the Spin gap. Spin does not merely skip inline admin stubs; it skips all six first-party route bindings (proxy, click, sign, proxy-rebuild), which carry real traffic. Cloudflare, by contrast, has no health route and so covers everything.
- Line references to correct:
settings.rs:166should be:215;auction/mod.rs:49points at the function header rather than the list;publisher.rs:4361should be:4369.
§8 item 7 is the load-bearing finding
Your assessment is right and the cause is more fundamental than the text states. The Fastly adapter has no [lib] section and no src/lib.rs, and every module is declared bare mod, so nothing in the crate is externally reachable. This is not a visibility modifier to widen; it is a missing library target. Axum, Cloudflare, and Spin each expose pub fn routes_with_settings and pub struct TrustedServerApp; Fastly exposes neither.
As things stand the seam is proven on the dev server and unreachable on the primary deployment target. §6's acceptance criteria should require the round trip on Fastly specifically, not on any adapter. Under change 1 this stops blocking the immediate work, since in-tree integrations compile in and nothing needs runtime injection. It must still be fixed before the first external vendor crate, and per change 5 the fix may belong in edgezero rather than here.
Disposition of the open pull requests
#1043 through #1047 and #1094 are superseded rather than rejected. The design in §3.6 is accepted, and most of the provider logic carries over onto the reordered base. Please do not read this as the work being discarded.
The order, with the first two independent and able to run in parallel:
- One
crates/trusted-server-integrationscrate with a discoveringbuild.rs, againstmain. - Permissions into
trusted-server.toml,permissions.yamldeleted. - The EC provider work, rebased onto 1 and 2.
- Device and geo selection, in the same shape.
- Per-vendor crate extraction, if and when a vendor takes over maintaining one.
Happy to discuss who does what. The Fastly composition gap is core infrastructure rather than vendor contribution, and per change 5 it may not belong in this repository at all.
The jurisdiction default should not name a country
[geo] default_country is required in every mode, and it must resolve to a rule in the policy file. There are three groups today, being gdpr-eu, gdpr-uk, and us-opt-out, so a deployment with global traffic and no geo provider has to nominate one country and then apply that country's law to every visitor. That is the wrong shape. It makes a neutral product take a position on whose rules apply, and the operator's honest answer is usually "I do not know where this visitor is", not "treat everyone as French".
The default should be a policy baseline rather than a country. Two forms worth considering, and I do not mind which:
- A named group, so an operator selects
gdpr-euor a strictest-available baseline directly without claiming a location. - A per-permission baseline written inline, for an operator who wants to state exactly what is allowed with no signal.
Either way the value says what is permitted, not where the visitor supposedly is. The requires-signal floor already exists for a failed lookup, so the machinery for a location-free baseline is there.
This also removes most of what I was going to send to the task force. The UK row shipping necessary.operations.storage: granted while the EU requires a signal, and Australia mapping to us-opt-out, are still policy positions that need someone with the relevant expertise to confirm with a citation, and the shipped table should carry that citation. But nobody has to ratify a default that no longer asserts a jurisdiction.
The crate layout, the configuration format, and the merge order are not task force questions. They are engineering calls and we should settle them here.
One further item to fix wherever the permission work lands: §7 of the permission-model spec records that publisher navigation and page-bids attach user.id under the provider gate rather than the sharing pair, so a storage-only grant can still place the EC identifier in user.id on those paths while /auction pair-gates it. That is an open inconsistency in the sharing boundary, and it should be closed rather than tracked.
|
Thank you for this. It is a serious review and it moves the design forward. Taking your points in order. 1. One integrations crate with a discovering 2. Crate layout. Here we differ. Whether a vendor wrote the code, or the Tech Lab team wrote it for them, should not decide whether it gets its own crate. Separating per vendor now makes ownership legible, and a crate boundary is enforced by the compiler, while a CODEOWNERS entry only assigns review ownership and constrains nothing about what code can reach. The maintainer can be the Tech Lab team today. If the Tech Lab team built the Permutive integration, the Permutive crate is theirs until Permutive take it over, and the handover then changes one line, not the structure. We take the point that host code stays in its adapter, which §3.6 already says, and we will follow the repository's crate-naming convention. The disagreement is only on timing. 3. Permissions. This one is fundamental for us and not something we can change 🙂. Deleting the dedicated permissions file breaks a deployment model that is very hard to change later. The transparency point first. A single, dedicated permissions policy that anyone can open and read is how Trusted Server shows exactly what a publisher permits, on its own rather than buried beside proxy secrets and backend hosts. Then the mechanism. Trusted Server should not decide policy for the deployer, and there should be no automatic default. Selecting the policy is a conscious choice when an environment is set up for the first time. The entity that compiles a deployment provides the policy it wants as part of the build, which is why the policy has to be a build-time artifact and not only a runtime config section, and that same entity can expose configuration override so the operator of the compiled variant can adjust it without rebuilding. Consider a provider in Europe that compiles Trusted Server with a European base and ships it to its customers, who get an interface to tune it. Two actors and two moments, with the integrator setting the base at build time and the operator adjusting it at runtime. A single runtime config section cannot express that, and neither can a compiled-only policy, so both layers are required. The repository should also carry multiple policy files for different test scenarios, because exercising the permission model across scenarios is part of the robustness of the service. Three things follow. Policy is not locked in the binary forever. The compiled base is the layer these PRs implement, and the operator override is the follow-on the permission-model spec already records as deferred, so a jurisdiction rule can change on a regulator's timeline without a rebuild. What the shipped jurisdiction rules should say, the UK storage row and the country baselines included, is a policy question for the group to confirm with citations, which is your point in the jurisdiction section too, and we would take it there rather than settle it in code review. And which file carries the compiled-in base and which one arrives through configuration at runtime is not something engineers need to debate. That choice sits with the people deploying, and testing proves every mutation of base and override works. 4. The EC provider and one injection path. Agreed. §3.6 specifies one identity injection path and we will honor it, collapsing to the single registration path. An unresolvable selector will fail loudly, while an absent selector keeps today's behavior of running with no Edge Cookie provider. Rebased onto a seam that already exists, the double configuration migration also goes, so operators migrate once. 5. What belongs where. The distinction that matters is which repository these live in. The geo provider, the device provider and the Edge Cookie provider are part of Trusted Server, not EdgeZero. EdgeZero supplies the host plumbing, and the provider capabilities are Trusted Server's domain, which is where a vendor goes to plug in. They are also deliberately off by default. Only User-Agent device detection runs by default, geo resolves no location until a provider is configured, and the Edge Cookie provider is selected by configuration, which is the same conscious-choice principle as point 3. Vendor code already lives in Trusted Server as the registered integrations, and the provider seam exists so a vendor can be added the same way. We are asking to use it for the purpose it was built. Where you are right is the platform plumbing rather than the providers. The config, secret and KV stores that Spec corrections. Taken, and thank you for checking against the tree.
On merging. We agree with most of this and will make the changes. The differences are narrow, being per-vendor separation now rather than later and keeping a dedicated permissions file. Rather than treat the current PRs as superseded and reset, could we agree a concrete sequence and owners for landing this so the provider work merges soon? We would like to keep this a direct back and forth to a merge. Thanks again for the depth of the review. |
ChristianPavilonis
left a comment
There was a problem hiding this comment.
Summary
Requesting changes for three security or authorization failures and three contract gaps in the normative design. These findings are distinct from the existing feedback on sequencing, implementation status, Fastly composition, policy placement, and jurisdiction defaults.
Reviewed 180060402f91b4efa96f5823da8934d19c1c78f8 against d516a9e94249e10cbc36e41beb4269f9255cf407.
| page-script endpoint. The 2026-07-31 draft asked for an exact origin | ||
| allowlist as new configuration plus an optional session-bound CSRF | ||
| token. v1 derives the allowed set from `publisher.domain` (existing, | ||
| operator-trusted configuration) and admits the publisher's own |
There was a problem hiding this comment.
🔧 P1: Do not authorize every publisher subdomain to set identity
Authorizing every origin below publisher.domain recreates the identity-fixation path for a delegated, user-controlled, or compromised sibling subdomain. Such a page passes this suffix check and can issue the simple credentialed POST described in the threat model, while the EC cookie is scoped to .publisher.domain. Control of the DNS namespace does not imply that every subdomain is a trusted identity-setting origin. Please use an explicit serialized-origin allowlist and match scheme, normalized host, and effective port exactly. Add rejection cases for a sibling subdomain, the wrong scheme, and the wrong port.
| permission state and consent context so a provider can read them for | ||
| behavior beyond gating. The gate itself has already run before `generate` | ||
| is called, so a provider cannot use the fields to authorize itself. | ||
| - `required_permissions` on `DeviceProvider` and `PlatformGeo`: **present, |
There was a problem hiding this comment.
🔧 P1: Enforce or reject device-provider permission declarations
DeviceProvider::required_permissions is public but deliberately has no enforcement point, while the integration seam exposes DeviceProvider as an external vendor capability with request evidence and a possible shared backend. An external provider can therefore declare that its use requires permission and still run on every request. Operator selection is not a per-request consent decision. Please enforce the declaration before invoking a device provider, or reject nonempty device requirements until that gate exists. If the built-in classifier must run without advertising permissions, split that security role into a separate, narrowly scoped authority with restricted evidence and no general vendor egress.
| and reserialized. | ||
| - Every other admitted value-bearing source header in the exact mapping above | ||
| is singleton. Zero lines means omit the DataDome field. Exactly one valid | ||
| line is OWS-normalized and processed. Two or more lines, even identical, |
There was a problem hiding this comment.
🔧 P1: Duplicate request headers must not disable DataDome
Two instances of any admitted singleton header, including user-agent, origin, or authorization, currently skip the entire DataDome call through the fail-open path. Header multiplicity is attacker-controlled, and this spec requires adapters to preserve repeated field lines, so a bot can deliberately add a duplicate and receive the publisher response without validation. Please reject ambiguous security-singleton requests at the HTTP boundary, or omit an optional ambiguous field while still calling DataDome. Do not convert multiplicity into a protection bypass. Add duplicate-header cases to every adapter's qualification suite.
| marker shares the Edge Cookie's scope and lifetime and is expired | ||
| together with it on withdrawal, so a visitor who later re-establishes | ||
| the permission can resolve again. | ||
| - **The page leg is permission-gated before vendor contact.** The demo |
There was a problem hiding this comment.
🔧 P2: Define the browser permission-gating mechanism
This requires the vendor module to check the server's resolved permissions before vendor contact, but the design does not say how those permissions reach TSJS or combine with a fresh CMP check. Integration modules are self-executing IIFEs selected by provider configuration, while the endpoint gate runs only after the module may already have derived identity or contacted its vendor. A CMP signal alone also cannot reproduce the server's jurisdiction policy. Please define the browser-side authorization mechanism before the first vendor module lands, require module initialization to be side-effect free until that check passes, and add a browser test proving the vendor endpoint receives no request when permission is absent or withdrawn, including after BFCache restoration.
|
|
||
| - **The re-post guard must not depend on reading an HttpOnly cookie.** | ||
| Implemented as the draft's first option. The resolve response sets a | ||
| non-HttpOnly companion marker cookie (`ts-ecr=1`) carrying no identity, |
There was a problem hiding this comment.
🔧 P2: Bind the resolve marker to the selected provider
ts-ecr=1 records only that some client-cycle provider resolved in the past. On a switch from provider A to provider B, A's coded EC becomes unrecognized, but this marker remains until withdrawal or its one-year expiry. B's page script therefore sees the marker and never calls resolve, even though the migration contract says the switch restarts identity. Please bind the marker to the selected provider code and behavior revision, or expire it whenever the incoming EC is not recognized by the selected provider. Add an A-to-B client-provider switch test.
| APS can register from its own crate. Prebid stays in core as protocol | ||
| support rather than as a vendor integration. | ||
|
|
||
| The bid renderer contract is generalized in the same change. Today |
There was a problem hiding this comment.
🔧 P2: Add a browser renderer registration seam before moving APS
Generalizing Rust's BidRenderer is not enough to move APS out whole. TSJS core still imports parseApsRendererDescriptor from APS in core/auction.ts, imports APS dispatch in core/request.ts, and fixes AuctionBidRenderer to ApsRendererV1 in core/types.ts. Because build-all.mjs builds core/index.ts as a self-contained IIFE, those static imports remain in tsjs-core.js independently of carried integration modules. Please specify a browser renderer registry keyed by descriptor type. Integration modules should register their parser and dispatcher, core should reject unknown types safely, and a cross-language test should prove APS can be removed without changing or breaking the core bundle.
Rewrite the resolve endpoint's origin check as an exact serialized-origin
comparison, defaulting to the single origin https://{publisher.domain}
with an optional operator-configured list, and delete the sibling
subdomain justification that did not hold. Record that the origin check is
defense in depth under the provider's envelope verification, require the
sibling subdomain, wrong scheme and non-default port rejection cases, and
close open question 7.5.
Require core to expire the ts-ecr marker on any request carrying a ts-ec
the selected provider does not own, in both the client-cycle and pluggable
provider specs, so a provider switch restarts the client cycle instead of
leaving a visitor with a marker and no identity. Record the constraints on
carrying resolved permissions to the browser without designing the
mechanism, which belongs with the first vendor module.
Require a nonempty DeviceProvider::required_permissions from a
module-supplied provider to be refused at registry resolution rather than
described as a documented no-op.
Replace the DataDome singleton-header rule that skipped the vendor call on
a repeated field, which would have created an attacker-controlled bot
detection bypass and described no shipped behavior. Core now passes
repeated field lines through as received and leaves interpretation to the
vendor integration, keeping only the protocol-level content-length rule.
Correct the APS migration row and add a seam spec finding for the
pre-existing browser-side APS coupling in core TypeScript.
DeviceProvider::required_permissions is public but has no enforcement point. Device classification runs before the permission set for a request is assembled, so there is no per-request gate to check a declaration against, and selecting a provider is an operator decision rather than a per-request permission decision. Before the module seam that was a documented no-op, because core and the host supplied the only two providers and neither declares anything. With the seam a vendor crate can implement the trait, so the method reads as a promise that is not kept. Refuse the selection at registry resolution, loudly and at startup, rather than honoring the declaration by ignoring it. The refusal lifts when a real per-request device gate exists. Raised by Christian Pavilonis in review of IABTechLab#1084.
|
Thanks. Great review and I've checked the points. All six hold up. Five are changing in this stack, and one is real but is new design work that these PRs are not the place for. In order. P1, subdomain identity fixation. Agreed, and it is worse than you say. The check in The fix is the same-origin test of RFC 6454, so the request One more point on severity. The origin check is defense in depth here, not the primary control. The primary control is the provider's envelope verification with audience and session binding, which §3.9 parks out of v1. An exact allowlist does not help against a subdomain that legitimately serves publisher pages and is later compromised, so §3.9 still has to land with the vendor scheme. P1, device provider permissions. Agreed. I've taken your second option. A nonempty P1, duplicate headers and DataDome. Agreed on the risk, and I've changed the approach rather than patched the rule. One correction on the framing first. Nothing skips the call today because a header arrived twice. I haven't taken either remedy exactly, because both still have core deciding what to do with a vendor's evidence. Core should not invent header normalization for a vendor, and it certainly should not decide to skip a vendor call. Core passes the request headers through as received, repeated field lines preserved, and the vendor integration decides how to interpret multiplicity, because that is the vendor's detection logic and not core's business. The one field I am leaving out of that is The wider point, and it is the same separation argument running through this whole review. The DataDome logic sits in core today. Vendor detection logic of that kind belongs in the vendor's own module, behind the seam, not in the shared engine. Getting it there is the direction, and this rule is a small example of why. P2, the I've taken your second remedy rather than your first. Core expires the marker on any request carrying a P2, browser permission gating. Agreed, the mechanism was undefined. It is defined and delivered now, in the permissions PR (#1045). There are two deliveries. On the server, integration request filters receive the permission state resolved for the request, next to the geo result they already get, on the Fastly adapter, which is the only adapter that runs the filter step today. On the page, that same state arrives as Because the arrival point moves, core exposes A page module is treated the same way as any other provider. It declares the permissions it requires and checks them against the state it is handed before it does anything. The client-fixed demo script does exactly that now, declaring P2, the browser renderer seam. You are right, and it is out of scope for this stack. I've corrected the §4 APS migration row so it names the browser-side work as well as the Rust side, and added the coupling as a §8 finding. Designing the browser renderer registry belongs with the APS migration, not here, and I have filed it as #1111 so it is not lost in this thread. On scope. This stack is not adding new designs or features. It implements the seam that was agreed, and where it overclaims I've corrected the text rather than widened the specs to cover work these PRs will not deliver. The browser renderer registry is genuinely new design work. It is a good agenda item for the next meeting and I'd rather settle it there than in a review thread. Five changes are in the stack now, being the exact origin check with its rejection tests, the device permission rejection, the marker expiry, the DataDome pass-through rule, and the page and filter carriage of the resolved permissions. The other one is a spec correction that says plainly what is not yet designed. |
DeviceProvider::required_permissions is public but has no enforcement point. Device classification runs before the permission set for a request is assembled, so there is no per-request gate to check a declaration against, and selecting a provider is an operator decision rather than a per-request permission decision. Before the module seam that was a documented no-op, because core and the host supplied the only two providers and neither declares anything. With the seam a vendor crate can implement the trait, so the method reads as a promise that is not kept. Refuse the selection at registry resolution, loudly and at startup, rather than honoring the declaration by ignoring it. The refusal lifts when a real per-request device gate exists. Raised by Christian Pavilonis in review of IABTechLab#1084.
aram356
left a comment
There was a problem hiding this comment.
Permissions policy should use the existing typed app-config path
Requesting changes on the permissions.yaml decision.
The argument for a dedicated YAML file does not establish a technical guarantee. YAML is editable before a build, and include_str! only records a snapshot in that binary. It does not prove who selected the policy, that the repository file matches the deployed binary, or that a later build or deployment preserves it. If an immutable distributor floor is required, that needs an explicit trust model—such as signed build provenance, an exposed policy digest, and a merge rule under which runtime configuration can only tighten the floor. The file format itself does not provide that.
The current design also does not yet deliver the two-layer model described in the discussion: permissions.yaml is compiled in, while runtime overrides are deferred. As written, operational policy changes require rebuilding and redeploying, and the most compliance-sensitive configuration bypasses ts config validate, ts config diff, and ts config push.
We already have an appropriate configuration path:
- Add
permissions: PermissionsConfigtoSettings, besideconsent. - Serialize and deserialize it through
TrustedServerAppConfig. - Validate group references, permission identifiers, acquisition values, normalized location keys, and provider enforcement coverage in
validate_settings_for_deploy. - Publish it in the existing
BlobEnvelopewithts config push. - Construct
PermissionMapsfromsettings.permissionsonce at startup.
The TOML can represent the same concepts: a location-independent default_group, named groups or baselines, country/region-to-group rules, and consent-signal mappings. A default_group also avoids pretending that a visitor with unknown geography belongs to a made-up default_country.
Please revise the spec so the effective operational policy lives under [permissions] in trusted-server.toml and participates in the existing typed configuration lifecycle. If a compiled distributor floor is still required, specify it as a separate optional layer and define exactly:
- Who is trusted to choose it.
- How a deployed binary proves which floor it contains.
- Whether runtime configuration may only tighten it—for example,
granted < requires_signal < denied. - How the effective merged policy and its digest are exposed for audit.
Without those guarantees, a separate compiled YAML file adds a second configuration system and a rebuild requirement without delivering the immutability or auditability used to justify it.
There was a problem hiding this comment.
Vendor-owned crates should be an extension path, not the default migration
This is blocking because §4 makes separate vendor crates the required structure for integrations that are currently maintained together in this repository. I agree with the goal of allowing vendors to own their integrations independently. I do not agree that we should create those ownership boundaries before the owners and independent lifecycles actually exist.
A crate boundary should represent a real maintenance boundary: an independent owner, release process, dependency or licensing requirements, security-response responsibility, and compatibility commitments. The current integrations are reviewed under the same project governance, released with Trusted Server, and use largely the same dependencies. Moving each one into its own crate does not make it vendor-maintained. Unless a vendor has explicitly accepted those responsibilities, the Trusted Server team still owns the integration—only now it also owns another manifest, release surface, CI path, dependency-update stream, and compatibility obligation.
Separate Rust crates provide compile-time package boundaries. They do not by themselves provide runtime isolation, independent deployment, or the ability to add an integration without rebuilding Trusted Server. If all of these crates remain workspace dependencies compiled into the same binary, most deployment characteristics remain unchanged while repository and release complexity increase.
The current integrations should instead live as vendor modules in one crate:
crates/trusted-server-integrations/
src/
vendor_a/
vendor_b/
vendor_c/
That crate can still provide the intended provider interface, generated registration, and shared conformance tests. The interface should also allow an independently maintained external crate to implement the same contract. A vendor contribution can therefore start as a module in the shared crate or as a genuinely external implementation, depending on who owns its lifecycle.
An integration should be extracted into its own crate when at least one concrete boundary exists, for example:
- The vendor commits to owning releases, compatibility testing, and security fixes.
- The integration has materially different dependency or licensing requirements.
- It needs an independent release cadence.
- A real external integration demonstrates that the provider seam requires the separation.
Whether Trusted Server supports independently maintained vendor integrations is a product and governance decision. Whether every existing integration needs a separate crate is an engineering packaging decision, and the current ownership and release model does not justify it.
Please revise the spec to use one trusted-server-integrations crate for the integrations maintained here, with vendor-specific crates supported as an optional extraction path when real owners and lifecycle boundaries emerge. This preserves the vendor-owned extension model without creating a separate package for every hypothetical future owner.
aram356
left a comment
There was a problem hiding this comment.
Blocking: define and sequence the EdgeZero boundary before adding another platform layer
This is blocking. §3.6 states the right high-level rule—host-supplied capabilities are platform services—but the design does not carry that rule through to repository ownership or implementation sequence. Trusted Server already runs on EdgeZero. If we add the missing host-service and composition machinery here first, we create a second platform abstraction that every adapter and future integration must understand.
The overlap is concrete on current main:
edgezero-coreownsHooks,RequestContext, app configuration,BlobEnvelope, config/secret/KV store registries, proxying, routing, and middleware.Hooks::stores()is already the portable declaration that EdgeZero adapter runners use to provision and inject stores.RequestContextalready exposes named and default config, secret, and KV handles.- Each EdgeZero adapter already owns extraction of its native request context.
- Trusted Server's
RuntimeServicesseparately carries config store, secret store, KV store, HTTP client, backend, geo lookup, and client information.
That leaves the boundary ambiguous: some platform services flow through EdgeZero, while others are rebuilt and selected in Trusted Server. The provider seam should not make that duplication permanent.
What belongs in EdgeZero
-
Portable host-service access. Config, secret, and KV handles must continue to flow through EdgeZero's store registries and
RequestContext. Generic outbound HTTP/proxy access and platform transport/backend capabilities should also have one EdgeZero-owned contract. Trusted Server may use thin type adapters where its error or data types differ, but it should not own a second service registry or a second adapter-selection mechanism for the same host resources. -
Normalized host evidence. Client IP, TLS protocol/cipher, JA4/HTTP2 evidence, and host-provided geographic data are facts extracted by the deployment adapter. The portable evidence types and capability-presence metadata belong in
edgezero-core; the Fastly, Cloudflare, Spin, and Axum implementations belong in their EdgeZero adapters. Trusted Server should consume normalized evidence rather than reaching into platform SDKs or inventing a separate cross-adapter host context. -
Generic adapter lifecycle/composition hooks. If loading an application-supplied module requires a new startup, request-extension, or composition hook, the generic hook belongs in
edgezero_core::app::Hooksand must be honored by all four EdgeZero adapter runners. Fastly cannot have a separate composition rule. The payload carried through that hook can be Trusted Server-specific, but the adapter lifecycle mechanism cannot be. -
Host capability discovery. EdgeZero should expose which optional host capabilities are available so an application can fail startup when a selected provider requires unavailable evidence or transport. The provider requirement remains a Trusted Server concept; the authoritative statement of what the current adapter supplies belongs to EdgeZero.
What remains in Trusted Server
IntegrationRegistration, vendor JavaScript, prepare/finalize hooks, auction providers, configuration selection, and conformance tests.EdgeCookieProvider,GeoProvider, andDeviceProviderbehavior, including vendor calls, selection, per-request sharing, and permission enforcement.- HMAC identity, the User-Agent classifier, and other Tech Lab-owned implementations.
- Permission and jurisdiction policy.
- Auction telemetry and other ad-tech-specific request/response behavior.
The important distinction is that a host geo lookup belongs in EdgeZero, while a vendor geo provider that interprets or augments geo data belongs behind the Trusted Server integration seam. Likewise, raw TLS/JA4/H2 evidence belongs in EdgeZero, while device classification based on that evidence remains Trusted Server behavior. Identity remains a Trusted Server provider, while the KV and secret-store plumbing it consumes remains EdgeZero infrastructure.
Required changes to this spec
Please make the dependency direction and sequencing normative:
- Define the missing portable host-evidence, transport, capability-discovery, and lifecycle/composition contracts in EdgeZero.
- Land and version those EdgeZero changes first.
- Upgrade Trusted Server to that EdgeZero version and consume the contracts through
HooksandRequestContext. - Make
TrustedServerAppdeclare its stores throughHooks::stores()instead of leaving the existing EdgeZero injection seam unused. - Keep
RuntimeServices, if it remains, as a Trusted Server request/provider context over EdgeZero handles and normalized evidence—not as an independently owned platform layer. - Require the external-registration round trip on Fastly, Axum, Cloudflare, and Spin through the same lifecycle contract. Any Trusted Server-specific library entry point can remain here, but it must not compensate for a missing generic EdgeZero adapter hook.
Until those prerequisites and ownership lines are recorded, §3.6 permits two competing platform seams and leaves each implementation PR to decide ad hoc what belongs upstream. That is exactly the architectural drift this design is supposed to prevent.
… registration capabilities Adopt the registration shape asked for in the review of PR 1043 and apply its rule consistently, so a module declares its identity, geo and device providers alongside its JavaScript and hooks (new section 3.6). Record the relationship to the pluggable-providers spec in PR 986, reorder the series so this spec and its core implementation precede PR 1043, and add the capabilities round trip to the acceptance list.
A probe integration built outside core and registered through an adapter exercised every seam end to end. Four things surfaced that reading the code did not: the operator CLI reaches deploy validation through a type that supplies no builders, so a vendor's own rules are skipped on the path an operator uses; a carried browser module's hash literal is hand-maintained and breaks on a checkout that rewrites line endings; a provider is resolved more than once per request, which the shared-backend principle needs a per-request context to fix; and one core reader still reads the APS renderer payload directly. Also records the construction-time verification of a carried module's declared hash.
The review of IABTechLab#1043 asked that spec changes land before the code that implements them, so a divergence is a decision taken in review rather than a ratification of something already merged. PRs IABTechLab#1043 to IABTechLab#1047 each carried the design document for their own step, and IABTechLab#1043 carried a 607-line spec describing device providers, geo providers, the permission model and the browser resolve endpoint, none of which is in that PR. Move all six series documents here, so this PR carries the complete normative set and no code: - 2026-07-30-pluggable-providers-design.md (from IABTechLab#1043) - provider-code-registry.md (from IABTechLab#1043) - 2026-07-30-permission-model-design.md (from IABTechLab#1045) - 2026-07-30-client-cycle-ec-resolve-design.md (from IABTechLab#1046, later revised by IABTechLab#1047) - 2026-07-30-integration-response-header-hook-design.md (from IABTechLab#1047) - 2026-07-30-provider-migration-rollout-design.md (from IABTechLab#1047) Each file is taken verbatim at the tip of the stack, so the later revisions are preserved: the provider-switching continuity section, the geo requires-signal floor, and the code-envelope paragraph IABTechLab#1047 added to the client-cycle spec. The revision-record tables are unchanged. No document's substance was edited. The only edits are to this spec's own status line, which said the PR adds one document and that the series specs land with IABTechLab#1047, and a revision-record row recording the move.
The rule that every trait method needs a production caller in the change that introduces it is right for a behavioural trait, where a method nothing calls is dead weight. It is wrong for an evidence interface, and we applied it there and should not have. An evidence interface describes what a request carries, not what today's code happens to read. Held to the caller rule it grows a method each time a vendor arrives, so a vendor cannot write against it and it cannot stay stable across a release. It also puts the boundary in the wrong place. What a provider may see is not the control, because what a provider may do with what it sees is the control, and that is the permission model's job. So RequestInfo carries what the request carries. The rule stands everywhere else. Addresses: docs/superpowers/specs/2026-07-30-pluggable-providers-design.md section 4, a rule applied to an interface it does not suit
"Mint" is jargon for something ordinary, which is making an identifier. It was defined in the glossary, so it was at least explained, but a reader should not need a glossary for the word that describes the main operation the specs are about. Fifty-one uses across five files, including the glossary row itself, now read create, creates, created or creating. Nothing else changed, so a reader comparing against the previous revision sees one word substituted and no argument altered. Addresses: plain language in documents others read
…style fixes Delete the reserved 51dd provider-code registry row so the unpublished vendor provider is not named in the public spec. Correct section 8's count from four to seven, replace several with many, and restructure clause-joining colons into separate sentences across the provider specs. The 51Degrees contribution attribution lines are kept deliberately.
The four series specs (client-cycle EC resolve, permission model, pluggable providers, migration and rollout) each carried a Status line saying they were implemented. The code they describe is only in PRs IABTechLab#1043 to IABTechLab#1047 and none of those is merged, so the line read as shipped behavior. Each now says Proposed, names the PR that carries the implementation and states that it is not yet on main, keeping the existing revision dates and notes. The integration provider seam spec carried counts and line references that do not hold on main at d516a9e. Corrected against that commit: - Section 4 said migration_guards.rs embeds "the thirteen vendor files". The directory holds 23 .rs files (2 infrastructure, 6 in nextjs/, 2 in datadome/, 13 top-level integration modules), the guard embeds 20 of them and 9 of those 20 belong to the nine vendors, with osano.rs and the two datadome/ files absent. builders() registers 13 integrations, which is a different 13 from the file count. - Section 3.5 gave no counts for the prepare and finalize calls. There are nine production prepare_request call sites across the four adapters and a tenth in core, and the single production finalize_response call site is in core rather than in any adapter. - Section 8 item 3 described a proxy resolving geo twice, which does not happen on main. The real double resolution is the adapter EC context build against handle_auction on POST /auction. - Section 8 item 5 understated the Spin gap and misdescribed Cloudflare. Cloudflare covers every route it registers and has no health route, while Spin skips its first-party bindings as well as its inline admin stubs. - Line references: settings.rs:166 to :215, auction/mod.rs:49 to the list at :51 to :53, publisher.rs:4361 to :4369. Section 6 now requires the round trip to be proven on the Fastly adapter, the primary deployment target, rather than on any adapter, because Fastly has no library target and the round trip otherwise only runs on the Axum dev server.
Rewrite the resolve endpoint's origin check as an exact serialized-origin
comparison, defaulting to the single origin https://{publisher.domain}
with an optional operator-configured list, and delete the sibling
subdomain justification that did not hold. Record that the origin check is
defense in depth under the provider's envelope verification, require the
sibling subdomain, wrong scheme and non-default port rejection cases, and
close open question 7.5.
Require core to expire the ts-ecr marker on any request carrying a ts-ec
the selected provider does not own, in both the client-cycle and pluggable
provider specs, so a provider switch restarts the client cycle instead of
leaving a visitor with a marker and no identity. Record the constraints on
carrying resolved permissions to the browser without designing the
mechanism, which belongs with the first vendor module.
Require a nonempty DeviceProvider::required_permissions from a
module-supplied provider to be refused at registry resolution rather than
described as a documented no-op.
Replace the DataDome singleton-header rule that skipped the vendor call on
a repeated field, which would have created an attacker-controlled bot
detection bypass and described no shipped behavior. Core now passes
repeated field lines through as received and leaves interpretation to the
vendor integration, keeping only the protocol-level content-length rule.
Correct the APS migration row and add a seam spec finding for the
pre-existing browser-side APS coupling in core TypeScript.
Sign-off row 6 said no vendor move needs a core change after this design. Section 8 item 8 now records that TSJS core still imports the APS renderer directly, so an APS move needs a browser renderer contract that this design does not provide. Row 6 now claims only the Rust side, which is what the design actually delivers.
…wording claims Prettier realigns table columns in six specs that the 1 September review edits widened, which the format-docs workflow checks. The client-cycle spec no longer says the origin check normalizes to an effective port, because origins_match compares the port as the browser wrote it and adds or removes nothing. The response-header-hook spec no longer claims Trusted Server rejects a malformed or body-inconsistent content-length, because no core code does that. It is HTTP framing handled by the host HTTP layer, and the point that matters is that no integration reads the value.
The client-cycle spec described the origin check as a string comparison of the serialized origin. The implementation on the client-resolve branch now applies the RFC 6454 same-origin test, comparing the scheme, host and port triple with a missing port meaning the scheme's default, so the spec names that rule and the RFC rather than describing a comparison of its own.
…s and the page The pluggable-providers spec said a geo declaration is refused like a device one, but nothing consults PlatformGeo::required_permissions and its own body says so, so the summary now names device only. The permission-model spec records that a module device provider may not declare a permission, because the registry refuses one at startup. The client-cycle spec says the demo page script now declares and checks its required Data Use through tsjs.whenPermissions(), that the head script needs a head to inject into, that a bot-classified visitor receives the state resolved for the request rather than an empty one, and what the promise resolves with when nothing arrives.
The rules section of permissions.yaml becomes one tree, and [geo] default_country retires. Every node carries a group with optional children, country codes sit at the first level and region codes beneath them, a node written as a single string is shorthand for that group with no children, and matching runs region, then country, then the top node. The top node is the only one that also requires a jurisdiction, whose values come from the Jurisdiction type in crates/trusted-server-core/src/consent/jurisdiction.rs, and it states the baseline and the consent handling for a request whose country cannot be resolved. The permission model spec carries the change in its format, validation, resolution and failure-mode sections, with the canonical example and a new section 12 recording each before and after row and the date. The providers and rollout specs follow, where the configuration example, the startup-error rows and the migrated operator configuration drop default_country and point at the top node instead. Historical ledger rows keep what earlier pull requests implemented and gain a note naming the restructure, so the record still reads true. The audience for permissions.yaml is a policy owner rather than a developer, so the nesting shows precedence on the page instead of hiding it in slash-joined keys. Trusted Server encodes no jurisdiction's law, as the deployer states the policy and the software only carries it out.
Jurisdiction::from_policy_name in crates/trusted-server-core/src/consent/jurisdiction.rs reads a US state as us-state/<CODE>, for example us-state/CA, rather than the shorter form the format section first listed. The section now names the four accepted values as the parser spells them and records that any other value is a configuration error. Trusted Server encodes no jurisdiction's law, as the deployer states the policy and the software only carries it out.
The rules tree carries jurisdiction on any node, not only at the top. A node without one inherits the nearest ancestor that has one, the top node must carry both group and jurisdiction so the inheritance always terminates, and group and jurisdiction fall back independently, so the two answers for a visitor need not come from the same node. The us-state value drops its state code, because the region node it sits on already names the state, which also makes the value invalid at the top and on a country node. Section 3.4, which recorded one source of jurisdiction truth as deferred, is now adopted. consent.gdpr.applies_in and consent.us_states.privacy_states retire into the tree, where the shipped file holds the same 31 GDPR countries inheriting gdpr from the top node and the same 20 states with a comprehensive privacy law as region children of US carrying jurisdiction: us-state, so the drift the draft named has nothing left to drift against. The consumer side stays open, as auction dispatch still reads the consent subsystem's gate. The format, validation, resolution and failure-mode sections carry the change, section 12 gains a row for each of the three extensions, and the providers and rollout specs pick it up where they describe the top node and the migrated operator configuration. Trusted Server encodes no jurisdiction's law, as the deployer states the policy and the software only carries it out.
A geo provider that reports an outright lookup failure resolves every permission to the requires-signal floor and its jurisdiction to unknown, rather than reaching the tree at all. Section 5.2 and the failure-mode matrix now say so, matching what permissions.yaml states for the same case. Trusted Server encodes no jurisdiction's law, as the deployer states the policy and the software only carries it out.
…named owners The 3.6 list loosely named the host geo lookup among the platform services, which contradicted the design's own rule that geo is a provider a deployer selects, with a host lookup only one data source an implementation may consume. The 4 migration rule now also requires each migrated vendor crate to carry a visible maintainers declaration, the way Prebid.js requires of every adapter, and per-crate code ownership, so a crate boundary carries a named owner from its first day. The deployer selects providers, and the software encodes no vendor's or jurisdiction's choice.
Section 3.6 keeps its rule and now records that the client IP and the TLS, JA4 and HTTP/2 signals are candidates to migrate behind an EdgeZero evidence contract when one exists, which the review discussion on this PR proposed. Also replace a clause-joining semicolon in the same paragraph with a full stop.
DeviceProvider::required_permissions is public but has no enforcement point. Device classification runs before the permission set for a request is assembled, so there is no per-request gate to check a declaration against, and selecting a provider is an operator decision rather than a per-request permission decision. Before the module seam that was a documented no-op, because core and the host supplied the only two providers and neither declares anything. With the seam a vendor crate can implement the trait, so the method reads as a promise that is not kept. Refuse the selection at registry resolution, loudly and at startup, rather than honoring the declaration by ignoring it. The refusal lifts when a real per-request device gate exists. Raised by Christian Pavilonis in review of IABTechLab#1084.
2a08aec to
687ea90
Compare
DeviceProvider::required_permissions is public but has no enforcement point. Device classification runs before the permission set for a request is assembled, so there is no per-request gate to check a declaration against, and selecting a provider is an operator decision rather than a per-request permission decision. Before the module seam that was a documented no-op, because core and the host supplied the only two providers and neither declares anything. With the seam a vendor crate can implement the trait, so the method reads as a promise that is not kept. Refuse the selection at registry resolution, loudly and at startup, rather than honoring the declaration by ignoring it. The refusal lifts when a real per-request device gate exists. Raised by Christian Pavilonis in review of IABTechLab#1084.
DeviceProvider::required_permissions is public but has no enforcement point. Device classification runs before the permission set for a request is assembled, so there is no per-request gate to check a declaration against, and selecting a provider is an operator decision rather than a per-request permission decision. Before the module seam that was a documented no-op, because core and the host supplied the only two providers and neither declares anything. With the seam a vendor crate can implement the trait, so the method reads as a promise that is not kept. Refuse the selection at registry resolution, loudly and at startup, rather than honoring the declaration by ignoring it. The refusal lifts when a real per-request device gate exists. Raised by Christian Pavilonis in review of IABTechLab#1084.
DeviceProvider::required_permissions is public but has no enforcement point. Device classification runs before the permission set for a request is assembled, so there is no per-request gate to check a declaration against, and selecting a provider is an operator decision rather than a per-request permission decision. Before the module seam that was a documented no-op, because core and the host supplied the only two providers and neither declares anything. With the seam a vendor crate can implement the trait, so the method reads as a promise that is not kept. Refuse the selection at registry resolution, loudly and at startup, rather than honoring the declaration by ignoring it. The refusal lifts when a real per-request device gate exists. Raised by Christian Pavilonis in review of IABTechLab#1084.
Both specs still placed the permissions file at the repository root after the move to config/permissions/vanilla.yaml on the permissions branch.
DeviceProvider::required_permissions is public but has no enforcement point. Device classification runs before the permission set for a request is assembled, so there is no per-request gate to check a declaration against, and selecting a provider is an operator decision rather than a per-request permission decision. Before the module seam that was a documented no-op, because core and the host supplied the only two providers and neither declares anything. With the seam a vendor crate can implement the trait, so the method reads as a promise that is not kept. Refuse the selection at registry resolution, loudly and at startup, rather than honoring the declaration by ignoring it. The refusal lifts when a real per-request device gate exists. Raised by Christian Pavilonis in review of IABTechLab#1084.
|
For reviewers of this spec: the permission model it governs can now be seen working rather than read about. The inspector at https://jwrosewell.github.io/trusted-server/tools/permissions-inspector/ runs trusted-server-core compiled to WebAssembly against the repository's sample policy and shows which Data Uses are set for any visitor location and consent signals, with the reason per Data Use, the taxonomy definition behind each one, and the engine's version, branch and commit stated on the page. It ships in #1045 at |
Why this PR exists
PRs #1043 to #1047 open the identity, device and geo seams. A vendor can
ship an Edge Cookie provider in its own crate and an adapter injects it,
with no core change.
The nine vendor integrations already inside
trusted-server-core(APS,DataDome, Didomi, Google Tag Manager, GPT, Lockr, Osano, Permutive,
Sourcepoint) do not sit behind those seams. They hang off the integration
registry, which is a private table in core, so none of them can move out
until that table is opened.
This PR adds the design spec for that one core change, so the migration
of every existing vendor is a single defined piece of work rather than a
question asked again for each vendor.
Spec:
docs/superpowers/specs/2026-08-27-integration-provider-seam-design.mdThis PR adds one file, the spec, and no code. It targets
maindirectly so the diff is only that file. It reads alongside the series'
specs, which land with #1047.
What the spec says
Read against the tree at
split/5-response-hook-docs, with file and linereferences for every claim:
IntegrationRegistry::newtakes only&Settingsand iterates apub(crate)table(
integrations/registry.rs:797,integrations/mod.rs:290). Thepayload type is already public, so an outside crate can build a
registration but has nowhere to hand it.
js_module_idsservesa module only when
trusted_server_js::module_bundle(id).is_some()(
registry.rs:1169).config.rs:136to:166).(
auction/mod.rs:49).privacy and origin fetch decision (
publisher.rs:4367to:4387)and GPT diagnostics through direct calls in all four adapters.
The proposed change opens each of those in turn, keeps
new's signatureso no existing caller changes behavior, and names no vendor in core. It
also generalizes the bid renderer contract (
BidRendererinauction/types.rs:216has one variant,Aps), so APS moves out whole.The change is complete in itself: after it, no vendor move needs a core
change. It then sets out the migration of all nine integrations, one PR
each, with what each one needs.
Acceptance the spec sets for the implementation
trusted-server-core, carrying its own JavaScript, registeringthrough an adapter and appearing in the served bundle with the right
hash. A seam is only proven by an implementation that is not the
built-in one.
CLAUDE.md, on all four adapters.Governance question this raises
The spec's §2 states a principle for the task force rather than for the
compiler: Tech Lab engineering owns core and reviews vendor crates, and
vendors ship and maintain their own integrations. That is the change that
removes the per-vendor core work the project pays for today, most
recently in #1054.
Declared interest
51Degrees is a vendor and would use this seam for its own integration
(#1072). The reasoning here applies to every vendor on the same terms,
ourselves included, and our own provider follows the same route.
Provenance
An AI assistant produced this spec under my direction, from a read of the
current code. I have reviewed it. It needs human review before the
implementation is written.