esi pins fastly ^0.12, which blocks the fastly 0.13 upgrade #1122

Activity

1. aram356

   added

   dependenciesPull requests that update a dependency filePull requests that update a dependency file

   rustPull requests that update rust codePull requests that update rust code

   vendor dependency

   and removed

   dependenciesPull requests that update a dependency filePull requests that update a dependency file

   rustPull requests that update rust codePull requests that update rust code

   vendor dependency

   on Sep 6, 2026
2. aram356

   added the

   Task

   issue type on Sep 6, 2026
3. aram356 commented on Sep 7, 2026

   

   aram356

   on Sep 7, 2026

   CollaboratorAuthor

   More actions

   Verified end to end with the one-line fix applied locally, on Rust 1.98.1 and Viceroy 0.21.0.

   Cloned fastly/esi at v0.7.2, changed only the manifest range:

   -fastly = "^0.12"
   +fastly = "^0.13"

   No source changes to esi. cargo check -p esi --target wasm32-wasip1 compiles clean.

   With that referenced from [patch.crates-io] in trusted-server, both Fastly gates pass:

   • cargo clippy-fastly — clean under -D warnings
   • cargo test-fastly — 166 adapter tests (ESI assembly included), 2290 core, 2 js, 21 openrtb, 3 doctests; 0 failed

   So the version range is genuinely the only obstacle, and the resulting build is exercised rather than merely compiling.
4. aram356

   added a commit that references this issue on Sep 7, 2026

   Patch `esi` to a fork carrying the fastly 0.13 range

   ...

   e35e19c
5. aram356 commented on Sep 7, 2026

   

   aram356

   on Sep 7, 2026

   CollaboratorAuthor

   More actions

   Branch pushed to the fork: stackpop/esi@chore/fastly-0.13 (75bfbb396), branched from upstream v0.7.2.

   It turned out to be seven lines, not one. The library pin was the blocker, but the six examples pin fastly themselves, so they move with it — leaving them at 0.12 would build each example against a different SDK than the esi it links, which is the same two-copies problem one level down. Still no source changes to esi.

   PR #1123 now references that rev via [patch.crates-io], and both Fastly gates pass against it:

   • fastly 0.12 drops out of the graph entirely; one copy remains
   • cargo clippy-fastly — clean under -D warnings
   • cargo test-fastly — 166 adapter + 2290 core + 2 js + 21 openrtb + 3 doctests, 0 failed

   The patch in #1123 is temporary and marked as such; it should be dropped once the range bump is released upstream. An upstream PR against fastly/esi has not been opened yet.
6. aram356 commented on Sep 7, 2026

   

   aram356

   on Sep 7, 2026

   CollaboratorAuthor

   More actions

   esi's own test suite passes against fastly 0.13: 163 passed, 0 failed on wasm32-wasip1 under Viceroy 0.21.0, on the fork branch as pushed.

   So the change is verified on both sides — esi's suite against the new SDK, and trusted-server's full CI against the patched esi. That is the evidence an upstream PR would need.
7. aram356

   added a commit that references this issue on Oct 16, 2026

   Merge main and move EdgeZero to v0.0.10

   ...

   e7e7397
8. aram356 commented on Oct 16, 2026

   

   aram356

   on Oct 16, 2026

   CollaboratorAuthor

   More actions

   Status check on 2026-10-16: still no published version that works, so the [patch.crates-io] fork reference stays for now.

   • esi 0.7.2 (2026-08-20) is still the newest release and still declares fastly = "^0.12". There is no 0.7.3, 0.7.4 or 0.8.0.
   • fastly/esi main still reads ^0.12, and no open PR addresses it.
   • binary-install-style workarounds do not apply here; the range is the only blocker.

   Verified by removing the patch on the upgrade branch and resolving against the published crate:

   Adding fastly v0.12.1
   fastly copies in Cargo.lock: 0.12.1 and 0.13.1
   
   error[E0308]: mismatched types
      --> crates/trusted-server-adapter-fastly/src/esi_assembly.rs:96:9
   error[E0631]: type mismatch in closure arguments
      --> crates/trusted-server-adapter-fastly/src/esi_assembly.rs:124:65
   

   That is the original failure: the published crate pulls a second copy of the Fastly SDK into a graph where EdgeZero requires 0.13, and the two meet in esi_assembly.rs. The working tree was restored afterwards; PR #1123 is unchanged and passing 23/23.

   The exit condition for this issue is unchanged and now measured: a published esi whose fastly requirement admits 0.13. At that point the patch block in Cargo.toml becomes a plain version pin and this issue closes. The one-line change that achieves it is on stackpop/esi at chore/fastly-0.13 (rev 75bfbb396) and has not been proposed upstream.