Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions hypha/apply/activity/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ class Meta:
"message": PagedownWidget(),
}

def __init__(self, *args, user=None, **kwargs):
def __init__(self, *args, user=None, has_coapplicants=False, **kwargs):
super().__init__(*args, **kwargs)
self.visibility_choices = self._meta.model.visibility_choices_for(user)
self.visibility_choices = self._meta.model.visibility_choices_for(
user, has_coapplicants
)
visibility = self.fields["visibility"]
# Set default visibility to "Applicant" for staff and staff can view everything.
visibility.initial = self.visibility_choices[0]
Expand Down
9 changes: 7 additions & 2 deletions hypha/apply/activity/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,9 @@ def visibility_for(
return [ALL]

@classmethod
def visibility_choices_for(cls, user) -> List[Tuple[str, str]]:
def visibility_choices_for(
cls, user, has_coapplicants=False
) -> List[Tuple[str, str]]:
"""Gets activity visibility choices for the specified user

Args:
Expand All @@ -309,7 +311,10 @@ def visibility_choices_for(cls, user) -> List[Tuple[str, str]]:
]

if user.is_applicant:
return [(APPLICANT, VISIBILITY[APPLICANT])]
applicant_choices = [(APPLICANT, VISIBILITY[APPLICANT])]
if has_coapplicants:
applicant_choices.append((TEAM, VISIBILITY[TEAM]))
return applicant_choices

if user.is_reviewer:
return [(REVIEWER, VISIBILITY[REVIEWER])]
Expand Down
6 changes: 5 additions & 1 deletion hypha/apply/funds/views/comments.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ def comments_view(request, pk):

form = None
if user_can_view_post_comment_form(user=request.user, submission=submission):
form = CommentForm(user=request.user, data=request.POST or None)
form = CommentForm(
user=request.user,
data=request.POST or None,
has_coapplicants=submission.co_applicants.exists(),
)
if request.method == "POST":
form.instance.user = request.user
form.instance.source = submission
Expand Down