WIP: artifact-skill readiness probes (Refs #4407)#4461
Closed
CCChisato wants to merge 1 commit into
Closed
Conversation
Add a capability-level readiness model for bundled artifact skills (presentations, spreadsheets, PDFs, documents) that can distinguish Ready, Partial, NeedsSetup, and Unknown states. Changes: - New SkillReadiness enum (Unknown/Ready/Partial/NeedsSetup) and eadiness field on the Skill struct, defaulting to Unknown. - New ReadinessProbe trait + ProbeRegistry struct owned by the skill system. Global convenience singleton preserved for production; tests can create an isolated ProbeRegistry::new(). - MockProbe for deterministic test injection (no real OS commands). - PresentationsProbe (checks python3 + python-pptx) and SpreadsheetsProbe (checks python3 + openpyxl) registered via BundledSkill.probe field — probes are statically associated with skill entries, not hardcoded. - doctor --json per-skill readiness output with required_tools. - Runtime API SkillEntry.readiness populated on query. - TUI /skills display and /skill preview show readiness badge (pending rendering pipeline fix — badge IS in output string). - �ctivate_skill() appends readiness report instruction for NeedsSetup/Partial skills. - BUNDLED_SKILL_VERSION kept at 4 (no content migration needed). Test probe registered only in debug builds. Refs Hmbown#4407
Contributor
|
Thanks @CCChisato for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Capability-level readiness model for bundled artifact skills.
What works
What does NOT work
Design
Refs #4407