Skip to content

chore: remove legacy quick-add functionality#4447

Draft
Hmbown wants to merge 2 commits into
mainfrom
chore/remove-legacy-quick-add-6682938610938053130
Draft

chore: remove legacy quick-add functionality#4447
Hmbown wants to merge 2 commits into
mainfrom
chore/remove-legacy-quick-add-6682938610938053130

Conversation

@Hmbown

@Hmbown Hmbown commented Jul 17, 2026

Copy link
Copy Markdown
Owner

This PR removes the legacy # foo memory quick-add functionality from the composer's event loop, as Moraine recall is now considered stable. Inputs starting with # will now fall through to normal turn submission instead of being intercepted.

Changes include:

  • Removing the interception block in run_event_loop.
  • Deleting the is_memory_quick_add, should_intercept_memory_quick_add, and handle_memory_quick_add helper functions.
  • Deleting the dedicated memory_quick_add_tests test module.

Fixes #3490, #3495.


PR created automatically by Jules for task 6682938610938053130 started by @Hmbown

As Moraine recall is now stable, this removes the legacy `# foo`
memory quick-add functionality from the TUI event loop, allowing
such inputs to fall through to normal turn submission. Cleaned up
related dead code and tests.

Fixes #3490, #3495

Co-authored-by: Hmbown <101357273+Hmbown@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 17, 2026 01:37
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Hmbown Hmbown added this to the v0.9.4 milestone Jul 17, 2026
@claude

claude Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review in progress

  • Gather context (read diff, understand request)
  • Understand the request
  • Review diff for correctness, provider/model safety, reuse, tests, security
  • Post final review

View job run

@Hmbown
Hmbown marked this pull request as draft July 17, 2026 01:42
@Hmbown

Hmbown commented Jul 17, 2026

Copy link
Copy Markdown
Owner Author

Moved to v0.9.4 draft as the clean quick-add removal slice. Please change the body from Fixes #3490/#3495 to Related to: this PR alone satisfies neither issue and must not auto-close them. It can land only inside the coherent Moraine migration with replacement behavior and docs.

@google-labs-jules

Copy link
Copy Markdown
Contributor

Moved to v0.9.4 draft as the clean quick-add removal slice. Please change the body from Fixes #3490/#3495 to Related to: this PR alone satisfies neither issue and must not auto-close them. It can land only inside the coherent Moraine migration with replacement behavior and docs.

Understood. I will update the PR body to use "Related to:" instead of "Fixes", so the issues aren't automatically closed.

As Moraine recall is now stable, this removes the legacy `# foo`
memory quick-add functionality from the TUI event loop, allowing
such inputs to fall through to normal turn submission. Cleaned up
related dead code and tests.

Related to: #3490, #3495

Co-authored-by: Hmbown <101357273+Hmbown@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.9.3: Legacy follow-up and dead-code inventory: delete, wire, or track

2 participants