chore: remove legacy quick-add functionality#4447
Conversation
As Moraine recall is now stable, this removes the legacy `# foo` memory quick-add functionality from the TUI event loop, allowing such inputs to fall through to normal turn submission. Cleaned up related dead code and tests. Fixes #3490, #3495 Co-authored-by: Hmbown <101357273+Hmbown@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Understood. I will update the PR body to use "Related to:" instead of "Fixes", so the issues aren't automatically closed. |
As Moraine recall is now stable, this removes the legacy `# foo` memory quick-add functionality from the TUI event loop, allowing such inputs to fall through to normal turn submission. Cleaned up related dead code and tests. Related to: #3490, #3495 Co-authored-by: Hmbown <101357273+Hmbown@users.noreply.github.com>

This PR removes the legacy
# foomemory quick-add functionality from the composer's event loop, as Moraine recall is now considered stable. Inputs starting with#will now fall through to normal turn submission instead of being intercepted.Changes include:
run_event_loop.is_memory_quick_add,should_intercept_memory_quick_add, andhandle_memory_quick_addhelper functions.memory_quick_add_teststest module.Fixes #3490, #3495.
PR created automatically by Jules for task 6682938610938053130 started by @Hmbown