Skip to content

.toString() coerces null to string:null #76

Open
Open
.toString() coerces null to string:null#76

Description

@rkaw92
rkaw92
opened on Dec 21, 2016

Simple test case:

'use strict';

const Query = require('rql/query').Query;
const testPredicate = new Query().eq('foo', null);
console.log(testPredicate.toString());

Expected output:
eq(foo,null)

Actual output:
eq(foo,string:null)

Going to fix this in greatcare/rql, so that null values no longer get coerced. This is probably due to the special-case treatment of null in the first lines of query's encodeValue.

Activity

  1. rkaw92
    added a commit that references this issue on Dec 21, 2016

    Disable coercion of null values to string:null in Query#toString

    7986c6d

  2. wshager commented on Dec 21, 2016

    @wshager
    wshager
    on Dec 21, 2016
    Contributor

    @neonstalwart I see no problem with this fix, could you merge it? Who else has write permission nowadays?

  3. neonstalwart commented on Dec 21, 2016

    @neonstalwart
    neonstalwart
    on Dec 21, 2016
    Contributor

    I'm uncertain about my status to contribute to open source. I believe it's probably ok for me to merge something like this (since I'm not the author) but since I'm not certain I'd rather not. I know I can get permission to contribute code I've authored by having my contributions reviewed and approved by my employer before contributing but that extra step is just enough of a burden to make it more effort than I have the time and energy for right now. I'm not sure who else could merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions