fix: Prevent global state smashing#18
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request isolates Harper's home directory into a throwaway directory (dataRootDir) by setting the HOME and USERPROFILE environment variables. The reviewer pointed out that spreading options?.env after these variables could unintentionally overwrite them and defeat the isolation fix, and suggested spreading options?.env first to ensure the isolated paths take precedence.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
dawsontoth
force-pushed
the
prevent-global-state-smashing
branch
from
5e83125 to
5c8a3cb
Compare
heskew
approved these changes
Jun 16, 2026
Ethan-Arrowood
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I ran into this where I had run the integration tests on a clean machine, and then later in the day, I could not for the life of me figure out why I couldn't launch harper on an unrelated app! Claude helped me figure out the culprit -- I had aimed Harper at some ephemeral spot which had gotten cleaned up.
This helps our integration tests set the home dir so we don't touch the user's stuff!