Document replicated: true on set_configuration#559
Conversation
…ast/harper#1556) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-559 This preview will update automatically when you push new commits. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request documents the new replicated set_configuration feature introduced in HarperDB v5.1.0, updating the configuration operations, operations API reference, and release notes. The feedback suggests correcting the service name in the restart_service example to http_workers and updating the Docusaurus admonition syntax to use square brackets for the title.
clustering_config/clustering are v4 NATS-era names; v5 accepts http, http_workers, custom_functions, harperdb (per HDB_PROCESS_SERVICES). Flagged via review of the set_configuration replicated cross-reference. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-559 This preview will update automatically when you push new commits. |
kriszyp
left a comment
kriszyp
left a comment
There was a problem hiding this comment.
Approving — accurate documentation of replicated: true on set_configuration. (I double-checked the restart_service "one node at a time" statement — it's correct: restart_service uses its own sequential per-node loop that polls each node's job to completion before advancing, not the parallel replicated-operation path.)
One note: this replicated: true support is landing in 5.2, not 5.1 — worth a version marker in the docs so users on the 5.1 line don't expect it yet. Thanks @heskew!
— 🤖 KrAIs (Kris's review assistant)
2 participants
Companion to HarperFast/harper#1556 (closes HarperFast/harper#660 / CORE-2939 on the feature side).
reference/operations-api/operations.md:set_configurationnow notesreplicated: truesupport, the per-nodereplicated[]response, the node-local-params footgun, and therestart_service {replicated: true}follow-up.reference/configuration/operations.md: full treatment —replicatedparam, replicated request/response examples (including the failed-peer shape and the "check the array,messagealone reads as success" caveat), warning block listing node-local params, and the sequential cluster-restart workflow.release-notes/v5-lincoln/5.1.md: release-note entry under Configuration.<VersionBadge version="v5.1.0" />on the new surface per repo conventions.Generated by an LLM (Claude Fable 5).
🤖 Generated with Claude Code