Name the installed platform in the install completion message (#2263) - #3630
ayushcodes10 wants to merge 3 commits into
Conversation
Bare graphify install silently defaults to claude, and the completion message named no platform at all. A user following a platform neutral quick start for a different assistant such as Codex or OpenCode saw an apparently successful, generic message while the skill for their actual assistant was still absent, with nothing pointing them at the platform flag. The message now names the platform it just installed and gives a reminder of the flag to use for a different one, with an example that is never the platform just installed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Asserts the completion message names the platform that was actually installed and that the wrong assistant example never suggests the same platform. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![graphify-labs[bot]](https://avatars.githubusercontent.com/in/4356270?s=60&v=4){kind=small}
There was a problem hiding this comment.
Graphify reviewed this change.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Formal verification. No changes could be formally verified in this run.
Graphify review — findings
Adds the installed platform name to graphify install's completion message, so a bare install (which defaults to claude) now says "Installed the graphify skill for 'claude'." instead of a generic success line. Prints a "Wrong assistant?" hint with a --platform example that never repeats the platform just installed (falling back to codex, or claude when codex was the target) plus a pointer to --help, so users following a platform-neutral quick start notice a mismatch.
No blocking issues surfaced.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 742 functions depend on the 510 functions this change touches.
Health — this change adds coupling hotspots:
- new:
dispatch_command()— 2 callers, 125 callees - new:
codebuddy_install()— 20 callers, 5 callees - new:
claude_install()— 19 callers, 4 callees - new:
_copy_skill_file()— 12 callers, 6 callees - new:
gemini_install()— 10 callers, 7 callees - new:
claude_uninstall()— 17 callers, 4 callees - new:
_project_uninstall()— 5 callers, 13 callees - new:
dispatch_install_cli()— 2 callers, 31 callees - …and 14 more — each is listed as a finding
Verification — 742 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 661 function(s) in the blast radius were not formally verified this run
Test selection
Test selection
286 of 286 test file(s) selected (100%) via static blast radius.
Escalated to a full run for safety — the selection is not trustworthy on its own (see below). CI should run the whole suite.
tests/test_affected_cli.py— impact, full-run-safetytests/test_affected_member_seed.py— full-run-safetytests/test_agents_platform.py— impact, full-run-safetytests/test_analyze.py— full-run-safetytests/test_anthropic_custom_endpoint.py— full-run-safetytests/test_antigravity_install.py— full-run-safetytests/test_apm_fallback_version.py— full-run-safetytests/test_architecture_doc.py— full-run-safetytests/test_astro_extraction.py— full-run-safetytests/test_astro_import_ids.py— full-run-safetytests/test_atomic_canvas_export.py— full-run-safetytests/test_atomic_version_stamp.py— impact, full-run-safetytests/test_atomic_writes.py— full-run-safetytests/test_backend_env_isolation.py— full-run-safetytests/test_backend_extras.py— full-run-safetytests/test_benchmark.py— full-run-safetytests/test_benchmark_raw_graph.py— full-run-safetytests/test_build.py— full-run-safetytests/test_build_merge_dedup_scope.py— full-run-safetytests/test_build_merge_hyperedges_and_prune.py— full-run-safetytests/test_build_merge_shrink_guard.py— full-run-safetytests/test_builtin_global_type_refs.py— full-run-safetytests/test_cache.py— full-run-safetytests/test_callflow_html.py— full-run-safetytests/test_cargo_introspect.py— full-run-safetytests/test_carried_hyperedge_remap.py— full-run-safetytests/test_case_sensitive_resolution.py— full-run-safetytests/test_charmap_encoding.py— full-run-safetytests/test_chunking.py— full-run-safetytests/test_cjs_module_extension.py— full-run-safetytests/test_claude_cli_backend.py— full-run-safetytests/test_claude_md.py— impact, full-run-safetytests/test_cli_broken_pipe.py— full-run-safetytests/test_cli_export.py— full-run-safetytests/test_cli_help.py— full-run-safetytests/test_cluster.py— full-run-safetytests/test_codebuddy.py— impact, full-run-safetytests/test_community_hub_labels.py— full-run-safetytests/test_community_labels_skill.py— full-run-safetytests/test_confidence.py— full-run-safetytests/test_corrupt_graph_json.py— full-run-safetytests/test_cpp_nested_and_cli.py— full-run-safetytests/test_cpp_objc_cross_file_calls.py— full-run-safetytests/test_cpp_preprocess.py— full-run-safetytests/test_cross_extension_reexport_self_cycle.py— full-run-safetytests/test_cross_language_call_resolution.py— full-run-safetytests/test_cross_repo_external_call_guards.py— full-run-safetytests/test_cross_repo_member_calls.py— full-run-safetytests/test_cross_repo_shared_types.py— full-run-safetytests/test_csharp_call_site_generic_args.py— full-run-safety- … and 236 more
non-code file(s) changed (
CHANGELOG.md) → running the full suite for safety (a code graph can't see config/fixture/data deps)
changed code file(s) with no mapped test (
CHANGELOG.md) — a coverage gap or a missing link — running the full suite rather than only the selected tests
Selection is safe under the controlled-regression assumption; always-run tests + a periodic full run are the backstops. Advisory — it never changes the check verdict.
Formal verification
Could not verify: Could not verify install.
The verifier did not have enough to check install, so it is saying so rather than guessing. No false assurance is the whole point.
Guarantee: No guarantee either way, this is an honest abstention, not a pass.
Note: Reason: no capturable inputs from the test suite; property tier: not verifiable: all 23 sampled inputs raised on both versions — the function never executed, so 'no divergence' would be vacuous (mostly SystemExit — names the real obstacle, not a sampling gap)
· 22 more finding(s) on lines outside this diff (see the check run).
1 participant
Summary
Addresses #2263. Bare `graphify install` silently defaults to the `claude` platform, and the completion message named no platform at all: "Done. Open your AI coding assistant and type: /graphify ." A user following a platform-neutral quick start for a different assistant (Codex, OpenCode) saw this apparently-successful, generic message while the skill for their actual assistant was still absent, with nothing pointing them at `--platform`.
This addresses acceptance criterion 2 from the issue ("`graphify install` reports which platform and destination it installed") directly — the destination path is already printed by the existing per-file lines, so naming the platform explicitly closes the remaining gap. The issue's other suggestions (quick-start doc rewording,
graphify codex installdetecting a missing skill, interactive platform selection) are separate, larger changes not addressed here.Fix
The completion message now reads:
```
Done. Installed the graphify skill for 'claude'.
Wrong assistant? Re-run with e.g. `graphify install --platform codex`
(see `graphify install --help` for the full platform list).
```
The example platform in the "wrong assistant" hint is chosen to never match the platform that was just installed (so a Codex install correctly suggests `--platform claude` as the example, not `--platform codex`).
Test plan
🤖 Generated with Claude Code