Skip to content

Migrate partially resource_compute_instance.go.tmpl to use direct HTTP rather than a client library#17536

Draft
nsamartsev wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-instance-alias-ip-refactor
Draft

Migrate partially resource_compute_instance.go.tmpl to use direct HTTP rather than a client library#17536
nsamartsev wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-instance-alias-ip-refactor

Conversation

@nsamartsev
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Migrate partially `resource_compute_instance.go.tmpl` to use direct HTTP rather than a client library

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 825dab2:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 76 insertions(+), 37 deletions(-)
google-beta provider View Diff 2 files changed, 76 insertions(+), 37 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1446 1351 93 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 825dab2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants