Skip to content

backupdr: add guest_flush field to backup plan resource and data source#17524

Merged
roaks3 merged 3 commits into
GoogleCloudPlatform:mainfrom
gitika-yadav:backup-dr-guest-flush-v2
May 14, 2026
Merged

backupdr: add guest_flush field to backup plan resource and data source#17524
roaks3 merged 3 commits into
GoogleCloudPlatform:mainfrom
gitika-yadav:backup-dr-guest-flush-v2

Conversation

@gitika-yadav
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

backupdr: added `guest_flush` field to `google_backup_dr_backup_plan` resource and `google_backup_dr_backup` data source.

@github-actions github-actions Bot requested a review from roaks3 May 12, 2026 19:37
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c157a4c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 261 insertions(+), 11 deletions(-)
google-beta provider View Diff 6 files changed, 261 insertions(+), 11 deletions(-)
terraform-google-conversion View Diff 5 files changed, 103 insertions(+), 3 deletions(-)

Missing doc report (experimental)

The following data sources are missing documents:

  • google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.

Test report

Analytics

Total Tests Passed Skipped Affected
36 22 12 2
Affected Service Packages
  • backupdr

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_diskUpdate
  • TestAccBackupDRBackupPlan_fullUpdate

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccBackupDRBackupPlan_diskUpdate
✅ Log TestAccBackupDRBackupPlan_fullUpdate

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@gitika-yadav, @roaks3 VCR tests complete for c157a4c!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 835db5a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 259 insertions(+), 9 deletions(-)
google-beta provider View Diff 5 files changed, 257 insertions(+), 8 deletions(-)
terraform-google-conversion View Diff 5 files changed, 106 insertions(+)

Missing doc report (experimental)

The following data sources are missing documents:

  • google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.

Test report

Analytics

Total Tests Passed Skipped Affected
36 24 12 0
Affected Service Packages
  • backupdr

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@gitika-yadav, @roaks3 VCR tests complete for 835db5a!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f10a933:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 257 insertions(+), 8 deletions(-)
google-beta provider View Diff 5 files changed, 257 insertions(+), 8 deletions(-)
terraform-google-conversion View Diff 5 files changed, 106 insertions(+)

Missing doc report (experimental)

The following data sources are missing documents:

  • google_backup_dr_backup_plan, expect file /website/docs/d/backup_dr_backup_plan.html.markdown to exist.

Test report

Analytics

Total Tests Passed Skipped Affected
36 24 12 0
Affected Service Packages
  • backupdr

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@gitika-yadav, @roaks3 VCR tests complete for f10a933!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants