Skip to content

Feature/network validation#17522

Draft
bprachet wants to merge 12 commits into
GoogleCloudPlatform:mainfrom
bprachet:feature/network-validation
Draft

Feature/network validation#17522
bprachet wants to merge 12 commits into
GoogleCloudPlatform:mainfrom
bprachet:feature/network-validation

Conversation

@bprachet
Copy link
Copy Markdown
Contributor

@bprachet bprachet commented May 12, 2026

feat: Add network_resources validation for Cluster Director

This change adds a pre-create validation to ensure the network_resources field is set and not empty when resource for Cluster Director.

Fixes b/495546305

clusterdirector: Added validation to require at least one `network_resources` block during creation of cluster resource

@bprachet bprachet marked this pull request as ready for review May 12, 2026 16:33
@github-actions github-actions Bot requested a review from SirGitsalot May 12, 2026 16:33
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7023962:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 93 insertions(+)
google-beta provider View Diff 2 files changed, 93 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 0 1 5
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
  • TestAccHypercomputeclusterCluster_inPlaceUpdates
  • TestAccHypercomputeclusterCluster_networkValidation
  • TestAccHypercomputeclusterCluster_new
  • TestAccHypercomputeclusterCluster_update

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccHypercomputeclusterCluster_networkValidation
❌ Error · Log - TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
❌ Error · Log - TestAccHypercomputeclusterCluster_inPlaceUpdates
❌ Error · Log - TestAccHypercomputeclusterCluster_new
❌ Error · Log - TestAccHypercomputeclusterCluster_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@bprachet, @SirGitsalot VCR tests complete for 7023962!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9932bcc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 93 insertions(+)
google-beta provider View Diff 2 files changed, 93 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 1 1 4
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
  • TestAccHypercomputeclusterCluster_inPlaceUpdates
  • TestAccHypercomputeclusterCluster_new
  • TestAccHypercomputeclusterCluster_update

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
❌ Error · Log - TestAccHypercomputeclusterCluster_inPlaceUpdates
❌ Error · Log - TestAccHypercomputeclusterCluster_new
❌ Error · Log - TestAccHypercomputeclusterCluster_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@bprachet, @SirGitsalot VCR tests complete for 9932bcc!

@bprachet bprachet marked this pull request as draft May 12, 2026 17:02
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a15d1c5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 93 insertions(+)
google-beta provider View Diff 2 files changed, 93 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 1 1 4
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
  • TestAccHypercomputeclusterCluster_inPlaceUpdates
  • TestAccHypercomputeclusterCluster_new
  • TestAccHypercomputeclusterCluster_update

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
❌ Error · Log - TestAccHypercomputeclusterCluster_inPlaceUpdates
❌ Error · Log - TestAccHypercomputeclusterCluster_new
❌ Error · Log - TestAccHypercomputeclusterCluster_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@bprachet, @SirGitsalot VCR tests complete for a15d1c5!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e82ebfd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 78 insertions(+)
google-beta provider View Diff 1 file changed, 78 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 4 1 1
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHypercomputeclusterCluster_networkValidation

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccHypercomputeclusterCluster_networkValidation

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@bprachet, @SirGitsalot VCR tests complete for e82ebfd!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 25eee79:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 4134 insertions(+), 3465 deletions(-)
google-beta provider View Diff 2 files changed, 4134 insertions(+), 3465 deletions(-)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • hypercomputecluster

Please fix the compilation errors to complete your PR.

View the build log

@bprachet, @SirGitsalot VCR tests complete for 25eee79!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 08dad8b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 93 insertions(+)
google-beta provider View Diff 2 files changed, 93 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 1 1 4
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
  • TestAccHypercomputeclusterCluster_inPlaceUpdates
  • TestAccHypercomputeclusterCluster_new
  • TestAccHypercomputeclusterCluster_update

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
❌ Error · Log - TestAccHypercomputeclusterCluster_inPlaceUpdates
❌ Error · Log - TestAccHypercomputeclusterCluster_new
❌ Error · Log - TestAccHypercomputeclusterCluster_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@bprachet, @SirGitsalot VCR tests complete for 08dad8b!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6a62d02:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 93 insertions(+)
google-beta provider View Diff 2 files changed, 93 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 1 1 4
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
  • TestAccHypercomputeclusterCluster_inPlaceUpdates
  • TestAccHypercomputeclusterCluster_new
  • TestAccHypercomputeclusterCluster_update

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
❌ Error · Log - TestAccHypercomputeclusterCluster_inPlaceUpdates
❌ Error · Log - TestAccHypercomputeclusterCluster_new
❌ Error · Log - TestAccHypercomputeclusterCluster_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@bprachet, @SirGitsalot VCR tests complete for 6a62d02!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 12, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 43dd864:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 107 insertions(+)
google-beta provider View Diff 2 files changed, 107 insertions(+)
terraform-google-conversion View Diff 1 file changed, 28 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 5 1 0
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@bprachet, @SirGitsalot VCR tests complete for 43dd864!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4948824:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 107 insertions(+)
google-beta provider View Diff 2 files changed, 107 insertions(+)
terraform-google-conversion View Diff 1 file changed, 28 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 5 1 0
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@bprachet, @SirGitsalot VCR tests complete for 4948824!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9a3bb4a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 102 insertions(+), 5 deletions(-)
google-beta provider View Diff 2 files changed, 96 insertions(+)
terraform-google-conversion View Diff 1 file changed, 19 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 5 1 0
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@bprachet, @SirGitsalot VCR tests complete for 9a3bb4a!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fbcbb28:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 96 insertions(+)
google-beta provider View Diff 2 files changed, 96 insertions(+)
terraform-google-conversion View Diff 1 file changed, 19 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6 5 1 0
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@bprachet, @SirGitsalot VCR tests complete for fbcbb28!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants