Skip to content

add pubsub to spanner blueprint, IT, etc - #4366

Merged
derrickaw merged 4 commits into
GoogleCloudPlatform:mainfrom
derrickaw:20261004_pubsubToSpanner
Oct 14, 2026
Merged

derrickaw merged 4 commits into
GoogleCloudPlatform:mainfrom
derrickaw:20261004_pubsubToSpanner

Conversation

@derrickaw

@derrickaw derrickaw commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Add a new pubsub to spanner yaml blueprint and IT

@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.99%. Comparing base (9d6157e) to head (dadd9db).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4366      +/-   ##
============================================
+ Coverage     33.90%   37.99%   +4.09%     
- Complexity      509      517       +8     
============================================
  Files           215      195      -20     
  Lines         13251    11879    -1372     
  Branches       1335     1212     -123     
============================================
+ Hits           4493     4514      +21     
+ Misses         8388     6994    -1394     
- Partials        370      371       +1     
Components Coverage Δ
spanner-templates ∅ <ø> (∅)
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration ∅ <ø> (∅)
spanner-live-reverse-replication ∅ <ø> (∅)
spanner-bulk-migration ∅ <ø> (∅)
gcs-spanner-dv ∅ <ø> (∅)
see 23 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw added the addition New feature or request label Oct 4, 2026
@derrickaw
derrickaw marked this pull request as ready for review October 5, 2026 13:40
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Dataflow YAML template for streaming data from Pub/Sub to Cloud Spanner. The changes include the required metadata, configuration files, and a robust integration test suite to ensure the pipeline operates correctly in a production-like environment.

Highlights

  • New Template Implementation: Added a new Pub/Sub to Spanner YAML template, including the necessary Java interface, YAML configuration, and option definitions.
  • Documentation: Included a comprehensive README file detailing parameters, build instructions, and usage examples for the new template.
  • Integration Testing: Added a new integration test class to verify the functionality of the Pub/Sub to Spanner pipeline.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Pub/Sub to Spanner YAML template, including its Java metadata interface, YAML pipeline definition, documentation, and integration tests. The review feedback highlights syntax issues in the YAML template definition where filesToCopy and requirements are incorrectly formatted as strings/maps instead of sequences. Additionally, the schema parameter should be made optional as it is not required for all formats. In the integration tests, explicitly creating a Pub/Sub subscription and publishing messages once before the wait loop is recommended to prevent flakiness and duplicate message publishing.

Comment thread yaml/src/main/yaml/PubSubToSpanner.yaml Outdated
Comment thread yaml/src/main/yaml/PubSubToSpanner.yaml
@derrickaw derrickaw closed this Oct 13, 2026
@derrickaw
derrickaw force-pushed the 20261004_pubsubToSpanner branch from 5667ec9 to 9d6157e Compare October 13, 2026 17:55
@derrickaw derrickaw reopened this Oct 13, 2026
stankiewicz
stankiewicz previously approved these changes Oct 14, 2026
@derrickaw
derrickaw merged commit 44e5853 into GoogleCloudPlatform:main Oct 14, 2026
20 checks passed
@derrickaw

Copy link
Copy Markdown
Contributor Author

Merging since previously approved and the changes were suggested from a different PR. Thanks

@derrickaw
derrickaw deleted the 20261004_pubsubToSpanner branch October 15, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants