Repository navigation
add pubsub to spanner blueprint, IT, etc - #4366
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4366 +/- ##
============================================
+ Coverage 33.90% 37.99% +4.09%
- Complexity 509 517 +8
============================================
Files 215 195 -20
Lines 13251 11879 -1372
Branches 1335 1212 -123
============================================
+ Hits 4493 4514 +21
+ Misses 8388 6994 -1394
- Partials 370 371 +1
🚀 New features to boost your workflow:
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Dataflow YAML template for streaming data from Pub/Sub to Cloud Spanner. The changes include the required metadata, configuration files, and a robust integration test suite to ensure the pipeline operates correctly in a production-like environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the Pub/Sub to Spanner YAML template, including its Java metadata interface, YAML pipeline definition, documentation, and integration tests. The review feedback highlights syntax issues in the YAML template definition where filesToCopy and requirements are incorrectly formatted as strings/maps instead of sequences. Additionally, the schema parameter should be made optional as it is not required for all formats. In the integration tests, explicitly creating a Pub/Sub subscription and publishing messages once before the wait loop is recommended to prevent flakiness and duplicate message publishing.
5667ec9 to
9d6157e
Compare
|
Merging since previously approved and the changes were suggested from a different PR. Thanks |
Add a new pubsub to spanner yaml blueprint and IT