Fix PHONY label so make help advertises the real reqs target - #17
Merged
Merged
Conversation
.PHONY said docker-reqs, but the actual target has always been named
reqs -- running the advertised "make docker-reqs" silently no-ops
("Nothing to be done for 'docker-reqs'") instead of compiling
anything, since no such target exists. Traced to a commit that
renamed the label but never finished renaming the target itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`.PHONY` said `docker-reqs`, but the actual target has always been named `reqs`. Running the advertised `make docker-reqs` silently no-ops (`make: Nothing to be done for 'docker-reqs'.`) instead of compiling anything, since no such target exists -- worse than an error, since it looks like it succeeded.
Traced to a specific commit that renamed the `.PHONY` comment from `reqs` to `docker-reqs` but never finished renaming the actual target or its recipe. Every repo generated from this template inherited the same half-finished rename.
Decided to keep the name `reqs` rather than complete the rename to `docker-reqs`: every `reqs` target across every repo already runs via `docker compose run` internally and always has, so there's no real host-vs-docker distinction for the `docker-` prefix to disambiguate (unlike `docker-build`/`docker-test`/`docker-shell`, which each have a genuine non-docker alternative).
Verification
```
$ make help | grep reqs
reqs Compiles requirements.txt with pip-tools.
reqs-upgrade Upgrades requirements.txt with pip-tools.
```
Same fix applied in `gfw-ops`, `pipe-regions`, and (pending) `pipe-gaps`/`sftp-to-gcs`.