Repository navigation
Conversation
dangusev
added this pull request to stack #31
October 13, 2026 14:22
dangusev
force-pushed
the
fix/subscription-and-event-buffer-follow-ups
branch
2 times, most recently
from
October 13, 2026 14:54
2c2d055 to
57e6316
Compare
SubscriptionConfig::default() now subscribes to nothing, and the call started from it. Before an update_subscriptions call, set_incoming_video_enabled(true) gave video only, and false gave nothing, with no error. The call now starts from audio_all, as on main, so true gives audio and video and false gives audio only. JS setIncomingVideoEnabled also never removes audio.
Each call allocates all slots of three broadcast channels, about 464 B for each unit of capacity. A large value that passed the old check (tokio's panic bound) aborted the process at call creation. Client::new now returns Error::Config for a value above 65,536, which costs about 30 MiB for each call.
dangusev
force-pushed
the
fix/subscription-and-event-buffer-follow-ups
branch
from
October 13, 2026 15:02
57e6316 to
c33d00f
Compare
aliev
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬