Repository navigation
fix: stop sending deprecated SendStats fields - #14
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Sync the vendored SFU signal proto, which removes the deprecated SendStatsRequest raw-stats and input-device fields. The stats reporter no longer serializes raw getStats() strings; samples still ship as getstats records in rtc_stats, matching stream-video-js and stream-video-swift. Co-authored-by: Neevash Ramdial (Nash) <mail@neevash.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the vendored SFU signal proto with the latest
GetStream/protocolmain, which removes the deprecatedSendStatsRequestfieldssubscriber_stats,publisher_stats,audio_devices,video_devices,subscriber_rtc_stats, andpublisher_rtc_stats(nowreserved).The stats reporter no longer serializes the raw
getStats()reports into those strings. The same per-PeerConnection samples still reach the dashboard asgetstatsrecords insidertc_stats. This matches the public clients: stream-video-js #2488 and stream-video-swift #1353.rtc::protois exempt from compatibility guarantees; the change is noted inCHANGELOG.md.Verification
cargo fmt --all --check,cargo clippy --locked --all-targets --all-features -- -D warnings,cargo test --locked(285 lib tests + all integration suites, live),cargo test --locked --doc,RUSTDOCFLAGS="-D warnings" cargo doc --locked --no-depsSendStatstests: publisher and subscriber reports accepted with no error, and the subscriber rollup still carriesgetstats, ICE, andontrackrecordsexamples/join_calljoins and leaves cleanly