chore(react-native): clarify callingx registration for non-ringing calls

[santhoshvai]

💡 Overview

Clarify callingx registration logic by variable name changes.

📝 Implementation notes

removed the variable namings isIncomingCall isOutgoingCall isOngoingCall as it caused confusion

🎫 Ticket: https://linear.app/stream/issue/RN-436

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5c77f29d-b92b-4800-b3c8-290f0625ed74

📥 Commits

Reviewing files that changed from the base of the PR and between a948427 and e3bd875.

📒 Files selected for processing (1)

• packages/react-native-sdk/src/utils/internal/callingx/callingx.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

joinCallingxCall updates its call eligibility check and active-call filtering. It selects incoming-call handling based on ringing and creator status. Join and error logs now report those statuses.

Changes

Callingx join behavior

Layer / File(s)	Summary
Join eligibility and handling packages/react-native-sdk/src/utils/internal/callingx/callingx.ts	When ongoing calls are disabled, the function skips non-ringing calls. Active-call filtering retains ringing calls and eligible non-ringing calls, excluding loopback calls from the latter. Incoming-call handling and logs use ringing and creator status.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e3bd8

The join behavior preserves the existing eligibility and loopback-cleanup rules, while eligible non-ringing calls continue through startCall. No concrete merge-blocking risk is established.

Architecture Summary

Architecture risk: 🔵 Low · up to e3bd8

The change affects 1 system.

Changed systems: packages/react-native-sdk

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — packages/react-native-sdk (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in packages/react-native-sdk/src/utils/internal/callingx/callingx.ts: joinCallingxCall replaces its explicit incoming/outgoing/ongoing classification and combined eligibility check with an early return for non-ringing calls when ongoing calls are disabled. Active-call cleanup uses a non-ringing predicate that also excludes loopback calls; the leave operation and LEFT-state exclusion remain. Leave-failure logs now identify the method and include the error as a separate argument.
• observed — Modified behavior in packages/react-native-sdk/src/utils/internal/callingx/callingx.ts: The join log replaces incoming/outgoing classifications with the call’s ringing status and creator status. Incoming-call handling is now selected directly by call.ringing && !call.isCreatedByMe.
• observed — Modified behavior in packages/react-native-sdk/src/utils/internal/callingx/callingx.ts: The error log now reports ringing status and creator status instead of incoming/outgoing classifications, and uses the joinCallingxCall label.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the main change: clarifying CallingX registration for non-ringing calls.
Description check	✅ Passed	The description includes the required Overview, Implementation notes, and Ticket sections. It does not include the optional Docs link from the template, but the main change and related ticket are docu…

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Bundle size

Built package output. Sizes in KB; delta vs main@57f23a1.

Package	Unminified	Minified	Δ min vs main
@stream-io/video-client	805.2 KB	282.9 KB	+2.7 KB (+1.0%)
@stream-io/video-react-sdk	376.9 KB	229.2 KB	-10.2 KB (-4.3%)
↳ install total (+ client + react-bindings)	1211.8 KB	522.2 KB	-7.5 KB (-1.4%)
@stream-io/video-react-sdk (embedded) (cjs)	219.0 KB	127.0 KB	+564 B (+0.4%)
@stream-io/video-react-native-sdk	458.8 KB	208.5 KB	+9.2 KB (+4.6%)
↳ install total (+ client + react-bindings)	1293.6 KB	501.5 KB	+11.9 KB (+2.4%)
@stream-io/noise-cancellation-react-native	3.5 KB	1.0 KB	-234 B (-19.1%)