Improve trace timestamp accuracy under concurrent event recording#1734
Open
rahul-lohra wants to merge 1 commit into
Open
Improve trace timestamp accuracy under concurrent event recording#1734rahul-lohra wants to merge 1 commit into
rahul-lohra wants to merge 1 commit into
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
👮 Files not reviewed due to content moderation or server errors (2)
Warning Walkthrough skippedFile diffs could not be summarized. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal
Close #AND-1265
Improve the accuracy of trace timestamps by recording the timestamp when the trace event is created rather than when it is inserted into the tracer buffer.
Previously, timestamps were generated inside the synchronized buffer section. Under contention, a thread could wait to acquire the lock before recording its timestamp, causing the recorded time to reflect lock acquisition order rather than the actual time the event occurred.
By capturing the timestamp before acquiring the buffer lock, trace records more accurately represent when the underlying event was observed by the SDK.
Implementation
Before:
After:
This change improves the temporal accuracy of analytics and debugging traces when multiple threads are recording events concurrently.
🎨 UI Changes
None
Testing
Visit Stream Demo App's Dashboard to see the tracer events