Skip to content

fix(ci): skip no-commit-to-branch in the full-suite CI run #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nstarman merged 7 commits into from
Sep 15, 2026
Merged

fix(ci): skip no-commit-to-branch in the full-suite CI run #47

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
99a04b2
fix(ci): skip no-commit-to-branch in the full-suite CI run
nstarman Sep 15, 2026
c7a1b73
fix(ci): don't clobber an existing SKIP when skipping no-commit-to-br…
nstarman Sep 15, 2026
6cef4c1
docs(nox): clarify the no-commit-to-branch skip isn't CI-specific
nstarman Sep 15, 2026
6742e72
docs(nox): clarify the precommit session still runs via prek
nstarman Sep 15, 2026
431730e
docs(nox): fix now-inaccurate git-push mention in the SKIP comment
nstarman Sep 15, 2026
4e14e8d
docs: disambiguate "never fires on push" from the workflow's own push…
nstarman Sep 15, 2026
bb88425
docs: trim verbose inline comments down to the load-bearing WHY
nstarman Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# ///
"""Nox setup."""

import os
import shutil
from pathlib import Path

Expand All @@ -29,8 +30,11 @@ def lint(s: nox.Session, /) -> None:

@session(uv_groups=["lint"], reuse_venv=True)
def precommit(s: nox.Session, /) -> None:
"""Run prek."""
s.run("prek", "run", "--all-files", *s.posargs)
"""Run the pre-commit hooks (via prek)."""
# Not a real commit -- no-commit-to-branch would always fail here.
# Merge into any SKIP already set, rather than clobber it.
skip = ",".join(filter(None, [os.environ.get("SKIP"), "no-commit-to-branch"]))
s.run("prek", "run", "--all-files", *s.posargs, env={"SKIP": skip})


@session(uv_groups=["lint"], reuse_venv=True)
Expand Down
Loading