Add missing tests for codePushGradlePath - #50
Open
GhostCoder6969 wants to merge 1 commit into
Open
GhostCoder6969 wants to merge 1 commit into
GhostCoder6969 wants to merge 1 commit into
Conversation
GSTJ
approved these changes
Oct 5, 2026
GSTJ
left a comment
GSTJ
left a comment
Owner
There was a problem hiding this comment.
Thanks for this, glad it helped on the monorepo setup! Ran the suite locally at this commit and it's all green. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I noticed codePushGradlePath had no direct unit tests so I added a small spec for it. It pins the node resolve trick and the exact gradle string, 4 tests, full suite still green here. Let me know if you want anything tweaked, happy to adjust. Thanks for maintaning this, it saved me a headache on a monorepo setup.