Add a prototype addon that includes the formatter as a gdextension#305
Open
khellste wants to merge 1 commit into
Open
Add a prototype addon that includes the formatter as a gdextension#305khellste wants to merge 1 commit into
khellste wants to merge 1 commit into
Conversation
…don to support this gdextension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
Related issue (if applicable): #282
What kind of change does this PR introduce?
This PR introduces a gdextension build target for the formatter, allowing the formatter to run natively in the Godot editor rather than as a separate binary. It also adds a new "standalone" version of the addon that uses this gdextension instead of shelling out to the formatter binary.
Does this PR introduce a breaking change?
No.
New feature or change
What is the current behavior?
The Godot addon requires a separate formatter binary to be installed, and must call this binary in a separate process.
What is the new behavior?
The new Godot addon includes the formatter as a gdextension and runs the formatter natively in the Godot editor.
Other information