Goal: Make herdr orphan-pane reaping work in internal/herdr, atomically. (1) T - #350
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated task via
devagent task.Prompt
Goal: Make herdr orphan-pane reaping work in
internal/herdr, atomically. (1) ThreadsessionintoPaneForegroundWorker(sweep.go:245) and emit--sessionbeforepane process-info— today it is missing, so liveness is always false; update the roster.go:51 caller. (2) InFindStalePanes, evaluate orphan evidence (orphans && PaneRunOwnerOrphaned(paneID)) above the rostered-running spare (sweep.go:175) yet below theenvAttachedgate (FR-VIS-10: operator-attached still outranks orphan evidence) — else the fixed probe spares orphans asoperator-attachedand the class stays unreachable. (3) Sweep loop-dispatched main-checkout panes only with pane-run-owner evidence, sparing operator scratch panes. (4) Make test fakes assert--sessionon process-info. KeepDEVAGENT_HERDR_SWEEP_ORPHANSas kill-switch. Acceptance:go test ./internal/herdr/green with per-part regression tests.Repo policy: every PR keeps docs/PRD.md current — update the sections this change affects (status claims, architecture notes, roadmap/completion notes) and bump the Last updated footer in the same PR. A PR that changes repo state without reflecting it in docs/PRD.md is incomplete.
PRD state update (repo policy)