perf(rust): optimize hash12 by directly hex-encoding 6-byte digest slices in ja4 and ja4x - #314
Merged
Merged
Conversation
Member
vlvkobal
self-requested a review
August 27, 2026 13:52
added 6 commits
August 29, 2026 20:33
…es in ja4 and ja4x
…rgo clippy run step Signed-off-by: Aditya Dahale <aditya.dahale@example.com>
Signed-off-by: Aditya Dahale <aditya.dahale@example.com>
Signed-off-by: Aditya Dahale <aditya.dahale@example.com>
vlvkobal
reviewed
Aug 29, 2026
vlvkobal
approved these changes
Aug 31, 2026
vlvkobal
left a comment
Member
There was a problem hiding this comment.
One note for future PRs: a PR should have a clear idea behind it, and the changes in it should be coherent and related to that idea. Unrelated fixes, refactoring, and cleanup are better kept in separate PRs, otherwise the PR becomes harder to understand and review.
No need to split this one now, but please keep this in mind for future PRs.
Contributor
Author
|
Yes sir ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the core
hash12helper function in both theja4andja4xRust crates.Technical Details
Previously,
hash12performedhex::encode(Sha256::digest(s))over all 32 bytes of the digest into a 64-character heap string, followed bysha256[..12].into()to extract the 12-char slice: